Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$35] Show error if not all BAs were updated successfully #93

Closed
maxceem opened this issue Aug 12, 2021 · 6 comments
Closed

[$35] Show error if not all BAs were updated successfully #93

maxceem opened this issue Aug 12, 2021 · 6 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Aug 12, 2021

Sometimes when sending a request to update BAs for WP payments it can happen that some payments don't get their BA updated (perhaps it happens with in-progress payments) but the response has status code 200. As a result currently the corresponding modal gets closed and the user is not notified about not all BAs being updated.
Perhaps the modal should not be closed in this case and the payments' ids in the "Current BA(s) used" row should be updated.

@maxceem maxceem changed the title Show error if not all BAs were updated succesfully [$35] Show error if not all BAs were updated succesfully Aug 12, 2021
@maxceem maxceem changed the title [$35] Show error if not all BAs were updated succesfully [$35] Show error if not all BAs were updated successfully Aug 12, 2021
@maxceem maxceem added the CF Issues for Community Fixes label Aug 12, 2021
@MadOPcode
Copy link
Contributor

Implemented in #91.

@sandhiyakavi
Copy link
Collaborator

Verified in Dev Env.

Screenshot_3

Screenshot_4

image

@maxceem
Copy link
Contributor Author

maxceem commented Aug 17, 2021

Challenge https://www.topcoder.com/challenges/97209603-f9cc-4cca-be93-ec5194268921 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Aug 17, 2021

Challenge https://www.topcoder.com/challenges/97209603-f9cc-4cca-be93-ec5194268921 has been assigned to madopcode.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Aug 17, 2021

Payment task has been updated: https://www.topcoder.com/challenges/97209603-f9cc-4cca-be93-ec5194268921
Payments Complete
Winner: madopcode
Copilot: maxceem
Challenge 97209603-f9cc-4cca-be93-ec5194268921 has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Aug 17, 2021
@sandhiyakavi
Copy link
Collaborator

Difficult to test on Prod Env since it's an edge case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants