Rearranged payment actions menu items. Resolved some prop-types warnings.

Author: MadOPcode

src/components/JobName/index.jsx

@@ -24,7 +24,7 @@ const JobName = ({ className, jobId }) => {
 
 JobName.propTypes = {
   className: PT.string,
-  jobId: PT.oneOfType([PT.number, PT.string]).isRequired,
+  jobId: PT.oneOfType([PT.number, PT.string]),
 };
 
 export default memo(JobName);

src/routes/WorkPeriods/components/PaymentActions/index.jsx

@@ -29,6 +29,13 @@ const PaymentActions = ({ className, daysPaid, daysWorked, payment }) => {
 
   const actions = useMemo(
     () => [
+      {
+        label: "Edit Payment",
+        action() {
+          setIsOpenEditModal(true);
+        },
+        disabled: paymentStatus === PAYMENT_STATUS.IN_PROGRESS,
+      },
       {
         label: "Cancel Payment",
         action() {
@@ -38,13 +45,6 @@ const PaymentActions = ({ className, daysPaid, daysWorked, payment }) => {
           paymentStatus === PAYMENT_STATUS.CANCELLED ||
           paymentStatus === PAYMENT_STATUS.IN_PROGRESS,
       },
-      {
-        label: "Edit Payment",
-        action() {
-          setIsOpenEditModal(true);
-        },
-        disabled: paymentStatus === PAYMENT_STATUS.IN_PROGRESS,
-      },
     ],
     [paymentStatus]
   );

src/routes/WorkPeriods/components/PaymentModalUpdateBA/index.jsx

@@ -217,7 +217,7 @@ PaymentModalUpdateBA.propTypes = {
   ).isRequired,
   period: PT.shape({
     id: PT.string.isRequired,
-    jobId: PT.oneOfType([PT.number, PT.string]).isRequired,
+    jobId: PT.oneOfType([PT.number, PT.string]),
     projectId: PT.oneOfType([PT.number, PT.string]).isRequired,
     billingAccountId: PT.number,
     userHandle: PT.string.isRequired,