Fixed: inconsistent periods' selection state

If page size was greater than the total number of periods
select-all-on-page checkbox and the number of selected periods in the
message above the periods' table had incorrect state.

Author: MadOPcode

src/store/reducers/workPeriods.js

@@ -439,7 +439,15 @@ const actionHandlers = {
         delete periodsSelected[periodId];
       }
     }
-    if (Object.keys(periodsSelected).length === state.pagination.pageSize) {
+    const selectedCount = Object.keys(periodsSelected).length;
+    const pageSize = state.pagination.pageSize;
+    const totalCount = state.pagination.totalCount;
+    if (totalCount > pageSize) {
+      if (selectedCount === pageSize) {
+        isSelectedPeriodsVisible = true;
+      }
+    } else if (selectedCount === totalCount) {
+      isSelectedPeriodsAll = true;
       isSelectedPeriodsVisible = true;
     }
     return {
@@ -533,7 +541,15 @@ const actionHandlers = {
     const isSelected = !periodsSelected[periodId];
     if (isSelected) {
       periodsSelected[periodId] = true;
-      if (Object.keys(periodsSelected).length === state.pagination.pageSize) {
+      const selectedCount = Object.keys(periodsSelected).length;
+      const pageSize = state.pagination.pageSize;
+      const totalCount = state.pagination.totalCount;
+      if (totalCount > pageSize) {
+        if (selectedCount === pageSize) {
+          isSelectedPeriodsVisible = true;
+        }
+      } else if (selectedCount === totalCount) {
+        isSelectedPeriodsAll = true;
         isSelectedPeriodsVisible = true;
       }
     } else {
@@ -564,18 +580,22 @@ const actionHandlers = {
     };
   },
   [ACTION_TYPE.WP_TOGGLE_PERIODS_VISIBLE]: (state, on) => {
-    const isSelected = on === null ? !state.isSelectedPeriodsVisible : on;
+    let isSelectedPeriodsAll = false;
+    const isSelectedPeriodsVisible =
+      on === null ? !state.isSelectedPeriodsVisible : on;
     const periodsSelected = {};
-    if (isSelected) {
+    if (isSelectedPeriodsVisible) {
       for (let period of state.periods) {
         periodsSelected[period.id] = true;
       }
+      isSelectedPeriodsAll =
+        state.periods.length === state.pagination.totalCount;
     }
     return {
       ...state,
       periodsSelected,
-      isSelectedPeriodsAll: false,
-      isSelectedPeriodsVisible: isSelected,
+      isSelectedPeriodsAll,
+      isSelectedPeriodsVisible,
     };
   },
   [ACTION_TYPE.WP_TOGGLE_PROCESSING_PAYMENTS]: (state, on) => {