diff --git a/build.sh b/build.sh index 2c0184f..e83e5b2 100755 --- a/build.sh +++ b/build.sh @@ -4,6 +4,7 @@ APP_NAME=$1 UPDATE_CACHE="" docker build -f docker/Dockerfile -t $APP_NAME:latest \ +--build-arg SEGMENT_ANALYTICS_KEY=$SEGMENT_ANALYTICS_KEY \ --build-arg APPMODE=$APPMODE \ --build-arg APPENV=$APPENV . diff --git a/docker/Dockerfile b/docker/Dockerfile index e35bfa2..71f2789 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -3,9 +3,11 @@ FROM node:10.22.1 ARG APPMODE ARG APPENV +ARG SEGMENT_ANALYTICS_KEY ENV APPMODE=$APPMODE ENV APPENV=$APPENV +ENV SEGMENT_ANALYTICS_KEY=$SEGMENT_ANALYTICS_KEY # Copy the current directory into the Docker image COPY . /micro-frontends-frame diff --git a/package.json b/package.json index b015f5f..a898bec 100644 --- a/package.json +++ b/package.json @@ -2,9 +2,9 @@ "name": "@topcoder/micro-frontends-frame", "scripts": { "start": "node server.js", - "build": "webpack --mode=${APPMODE:-development} --env.config=${APPENV:-dev}", + "build": "webpack --mode=${APPMODE:-development} --env.APPENV=${APPENV:-dev} --env.SEGMENT_ANALYTICS_KEY=${SEGMENT_ANALYTICS_KEY:-NS}", "local-server": "nodemon ./server.js", - "local-client": "webpack-dev-server --mode=development --port 8080 --env.config=local", + "local-client": "webpack-dev-server --mode=development --port 8080 --env.APPENV=local", "lint": "eslint src --ext js", "test": "cross-env BABEL_ENV=test jest --passWithNoTests", "format": "prettier --write \"./**\"" diff --git a/src/index.ejs b/src/index.ejs index 14a3bf7..3b7984f 100644 --- a/src/index.ejs +++ b/src/index.ejs @@ -76,7 +76,7 @@ - <% if (!!htmlWebpackPlugin.options.templateParameters.SEGMENT_ANALYTICS_KEY) { %> + <% if (htmlWebpackPlugin.options.templateParameters.SEGMENT_ANALYTICS_KEY != "NS") { %>