Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 0d1ec24

Browse files
committed
Segment Analytics env fix during webpack build
1 parent a5fe86b commit 0d1ec24

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

docker/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ ARG APPMODE
55
ARG APPENV
66
ARG SEGMENT_ANALYTICS_KEY
77

8-
98
ENV APPMODE=$APPMODE
109
ENV APPENV=$APPENV
1110
ENV SEGMENT_ANALYTICS_KEY=$SEGMENT_ANALYTICS_KEY

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
"name": "@topcoder/micro-frontends-frame",
33
"scripts": {
44
"start": "node server.js",
5-
"build": "webpack --mode=${APPMODE:-development} --env.config=${APPENV:-dev}",
5+
"build": "webpack --mode=${APPMODE:-development} --env.APPENV=${APPENV:-dev} --env.SEGMENT_ANALYTICS_KEY=${SEGMENT_ANALYTICS_KEY:-NS}",
66
"local-server": "nodemon ./server.js",
7-
"local-client": "webpack-dev-server --mode=development --port 8080 --env.config=local",
7+
"local-client": "webpack-dev-server --mode=development --port 8080 --env.APPENV=local",
88
"lint": "eslint src --ext js",
99
"test": "cross-env BABEL_ENV=test jest --passWithNoTests",
1010
"format": "prettier --write \"./**\""

src/index.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
</single-spa-router>
7777
</template>
7878

79-
<% if (!!htmlWebpackPlugin.options.templateParameters.SEGMENT_ANALYTICS_KEY) { %>
79+
<% if (htmlWebpackPlugin.options.templateParameters.SEGMENT_ANALYTICS_KEY != "NS") { %>
8080
<!-- Segment Analytics Code -->
8181
<script type="text/javascript">
8282
!function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","debug","page","once","off","on","addSourceMiddleware","addIntegrationMiddleware","setAnonymousId","addDestinationMiddleware"];analytics.factory=function(t){return function(){var e=Array.prototype.slice.call(arguments);e.unshift(t);analytics.push(e);return analytics}};for(var t=0;t<analytics.methods.length;t++){var e=analytics.methods[t];analytics[e]=analytics.factory(e)}analytics.load=function(t,e){var n=document.createElement("script");n.type="text/javascript";n.async=!0;n.src="https://cdn.segment.com/analytics.js/v1/"+t+"/analytics.min.js";var a=document.getElementsByTagName("script")[0];a.parentNode.insertBefore(n,a);analytics._loadOptions=e};analytics.SNIPPET_VERSION="4.1.0";

webpack.config.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ module.exports = (webpackConfigEnv) => {
3232
inject: false,
3333
template: "src/index.ejs",
3434
templateParameters: {
35-
env: webpackConfigEnv.config,
36-
SEGMENT_ANALYTICS_KEY: process.env.SEGMENT_ANALYTICS_KEY,
35+
APPENV: webpackConfigEnv.APPENV,
36+
SEGMENT_ANALYTICS_KEY: webpackConfigEnv.SEGMENT_ANALYTICS_KEY,
3737
orgName,
3838
},
3939
}),

0 commit comments

Comments
 (0)