fix review comments

ThomasKranitsas · ThomasKranitsas · commit f66889b78439 · 2022-11-30T23:19:18.000+02:00
diff --git a/src/services/challengeService.js b/src/services/challengeService.js
@@ -62,7 +62,7 @@ async function save (challenge) {
   if (challenge.id) {
     // logger.debug(`Update Challenge ${challenge.id}`)
     // return
-    return updateChallenge(challenge, challengesInES)
+    return updateChallenge(challenge, challengesInES[0])
   }
   // logger.debug(`Create Challenge ${challenge.id}`)
   // return
@@ -341,7 +341,7 @@ async function getChallengeFromES (legacyId, full) {
     }
   }
   // Extract data from hits
-  return full ? docs.hits.hits : _.map(docs.hits.hits, item => ({
+  return full ? _.map(docs.hits.hits, item => item._source) : _.map(docs.hits.hits, item => ({
     legacyId: item._source.legacyId,
     legacy: {
       screeningScorecardId: _.get(item._source, 'legacy.screeningScorecardId'),

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ async function save (challenge) {`
`62`	`62`	`if (challenge.id) {`
`63`	`63`	// logger.debug(`Update Challenge ${challenge.id}`)
`64`	`64`	`// return`
`65`		`- return updateChallenge(challenge, challengesInES)`
	`65`	`+ return updateChallenge(challenge, challengesInES[0])`
`66`	`66`	`}`
`67`	`67`	// logger.debug(`Create Challenge ${challenge.id}`)
`68`	`68`	`// return`
`@@ -341,7 +341,7 @@ async function getChallengeFromES (legacyId, full) {`
`341`	`341`	`}`
`342`	`342`	`}`
`343`	`343`	`// Extract data from hits`
`344`		`- return full ? docs.hits.hits : _.map(docs.hits.hits, item => ({`
	`344`	`+ return full ? _.map(docs.hits.hits, item => item._source) : _.map(docs.hits.hits, item => ({`
`345`	`345`	`legacyId: item._source.legacyId,`
`346`	`346`	`legacy: {`
`347`	`347`	`screeningScorecardId: _.get(item._source, 'legacy.screeningScorecardId'),`