From 597e78bc81ae8ec634380c727b87fe2ff0ab24e4 Mon Sep 17 00:00:00 2001
From: vikasrohit <vikas.agarwal@appirio.com>
Date: Thu, 26 May 2016 10:41:33 +0530
Subject: [PATCH] AS#131482348128949, Refactor Mailchimp API wrapper to be
generic user preferences service
-- Code review suggestions
---
app/services/api.service.js | 2 --
app/services/userPreferences.service.js | 6 +++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/app/services/api.service.js b/app/services/api.service.js
index 36646fb26..6e6aa432d 100644
--- a/app/services/api.service.js
+++ b/app/services/api.service.js
@@ -74,8 +74,6 @@ import _ from 'lodash'
case 'SUBMISSIONS':
case 'USER':
return _getRestangularV3(CONSTANTS.AUTH_API_URL)
- case 'PREFERENCES':
- return _getRestangularV3(CONSTANTS.INTERNAL_API_URL)
default:
return _getRestangularV3()
}
diff --git a/app/services/userPreferences.service.js b/app/services/userPreferences.service.js
index 787e940d7..0245cc676 100644
--- a/app/services/userPreferences.service.js
+++ b/app/services/userPreferences.service.js
@@ -8,7 +8,7 @@ import angular from 'angular'
UserPreferencesService.$inject = ['$http', 'logger', 'Restangular', 'CONSTANTS', 'ApiService', '$q']
function UserPreferencesService($http, logger, Restangular, CONSTANTS, ApiService, $q) {
- var mailchimpApi = ApiService.getApiServiceProvider('PREFERENCES')
+ var preferencesApi = ApiService.getApiServiceProvider('PREFERENCES')
var service = {
getEmailPreferences: getEmailPreferences,
saveEmailPreferences: saveEmailPreferences
@@ -17,7 +17,7 @@ import angular from 'angular'
function getEmailPreferences(user) {
return $q(function(resolve, reject) {
- mailchimpApi.one('users', user.userId)
+ preferencesApi.one('users', user.userId)
.one('preferences', 'email').get()
.then(function(resp) {
resolve(resp.subscriptions)
@@ -52,7 +52,7 @@ import angular from 'angular'
settings.subscriptions = preferences
}
return $q(function(resolve, reject) {
- mailchimpApi.one('users', user.userId)
+ preferencesApi.one('users', user.userId)
.customPUT({ param: settings }, 'preferences/email')
.then(function(resp) {
resolve(resp.subscriptions)