From 92f9fc199ed8ae8790d7fcc22880ff35f8d6f296 Mon Sep 17 00:00:00 2001 From: vikasrohit Date: Tue, 12 Jan 2016 16:34:12 +0530 Subject: [PATCH 1/2] SUP-2901, [Edit Profile]: Add skill field should have full length even if there is no/few skills -- Fixed width of all sections in edit profile page using common fix instead of specific fix after getting go ahead for fixing the width of all sections to be same. --- assets/css/settings/settings.scss | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/assets/css/settings/settings.scss b/assets/css/settings/settings.scss index 1388ceb00..2936f84fa 100644 --- a/assets/css/settings/settings.scss +++ b/assets/css/settings/settings.scss @@ -145,20 +145,14 @@ margin-top: 10px; } } + .section-fields { + width: 100%; + } &.skills { input { width: 100%; } - .section-fields { - width: 100%; - } - } - - &.tracks { - .section-fields { - width: 100%; - } } } From 747a13de3fe88cd6345907cec66851c74edcaa8b Mon Sep 17 00:00:00 2001 From: vikasrohit Date: Wed, 13 Jan 2016 10:47:54 +0530 Subject: [PATCH 2/2] SUP-2901, [Edit Profile]: Improvements to the width of sections -- Applied suggested (by vikas) changes after getting go ahead in JIRA story. --- assets/css/directives/external-account.scss | 2 +- assets/css/directives/external-link-data.scss | 7 ++----- assets/css/settings/settings.scss | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/assets/css/directives/external-account.scss b/assets/css/directives/external-account.scss index 884fc6cb8..48d7525d7 100644 --- a/assets/css/directives/external-account.scss +++ b/assets/css/directives/external-account.scss @@ -4,7 +4,7 @@ display: flex; flex-direction: column; align-items: center; - margin: 5px 20px 15px 0; + margin: 5px 0px 15px 0; cursor: pointer; &.connected { diff --git a/assets/css/directives/external-link-data.scss b/assets/css/directives/external-link-data.scss index 24cc9a471..df5338d8b 100644 --- a/assets/css/directives/external-link-data.scss +++ b/assets/css/directives/external-link-data.scss @@ -3,6 +3,7 @@ external-accounts { display: flex; flex-flow: row wrap; + justify-content: space-between; } .ext-link-tile_edit-header { @@ -207,18 +208,14 @@ external-accounts { display: flex; flex-direction: row; flex-wrap: wrap; - justify-content: flex-start; + justify-content: space-between; padding: 0px 60px; .external-link-tile { border: 1px solid #f0f0f0; background-color: $gray-lightest; - margin-left: 15px; margin-top: 30px; margin-bottom: 0px; - // &:nth-child(3n+1) { - // margin-left: 0px; - // } width: 218px; height: 240px; display: flex; diff --git a/assets/css/settings/settings.scss b/assets/css/settings/settings.scss index 2936f84fa..96b565e5c 100644 --- a/assets/css/settings/settings.scss +++ b/assets/css/settings/settings.scss @@ -320,12 +320,12 @@ flex-direction: row; flex-wrap: wrap; margin-top: 20px; + justify-content: space-between; .skill { margin: 0 20px 10px; @media only screen and (min-width: 768px) { margin: 0; - margin-right: 30px; margin-bottom: 60px; } }