Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

[$20] - Remove extra marketing tags #979

Closed
dmessing opened this issue Feb 2, 2017 · 13 comments
Closed

[$20] - Remove extra marketing tags #979

dmessing opened this issue Feb 2, 2017 · 13 comments
Assignees

Comments

@dmessing
Copy link
Contributor

dmessing commented Feb 2, 2017

We have marketo and adroll but don't use them anymore on pages like https://www.topcoder.com/challenges please remove them

FYI

<script type="text/javascript"> adroll_adv_id = "LOUA2FVRTJDYZC2BMX72Z7"; adroll_pix_id = "4XU6H3BYL5EQBFHZM4DIUU"; (function () { var oldonload = window.onload; window.onload = function(){ __adroll_loaded=true; var scr = document.createElement("script"); var host = (("https:" == document.location.protocol) ? "https://s.adroll.com" : "http://a.adroll.com"); scr.setAttribute('async', 'true'); scr.type = "text/javascript"; scr.src = host + "/j/roundtrip.js"; ((document.getElementsByTagName('head') || [null])[0] || document.getElementsByTagName('script')[0].parentNode).appendChild(scr); if(oldonload){oldonload()}}; }()); </script> <script type="text/javascript"> document.write(unescape("%3Cscript src='//munchkin.marketo.net/munchkin.js' type='text/javascript'%3E%3C/script%3E")); </script> <script>Munchkin.init('921-UOU-112', {"wsInfo":"jFRS"});</script>
@dmessing
Copy link
Contributor Author

dmessing commented Feb 2, 2017

@ajefts & @birdofpreyru this might be an easy one to get tossed in

@birdofpreyru birdofpreyru changed the title Remove extra marketing tags [$10] - Remove extra marketing tags Feb 2, 2017
@birdofpreyru
Copy link
Collaborator

Expected Fix

Remove the mentioned marketo and adroll scripts from the pages served both from this repo, and from https://github.com/appirio-tech/tc-site, and ensure, that it does not break anything.

@lijulat
Copy link
Contributor

lijulat commented Feb 2, 2017

Can I try to fix ?

@birdofpreyru
Copy link
Collaborator

@lijulat Sure! It is yours.

birdofpreyru referenced this issue in topcoder-archive/appirio_tech-tc-site Feb 2, 2017
@birdofpreyru
Copy link
Collaborator

@lijulat Also remove the KISSmetrics scripts from both repos. As you remember, you have added this script to tc-site earlier to fix the missing user menu (#932) it turns out, that this analytics is not used anymore, so should be removed, and all references to it should be properly cleaned out, in the way that nothing is broken as that menu.

@birdofpreyru birdofpreyru changed the title [$10] - Remove extra marketing tags [$20] - Remove extra marketing tags Feb 2, 2017
@birdofpreyru
Copy link
Collaborator

@lijulat Any update?

@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru Apologies will raise a PR soon

@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru A quick question should google analytics stay?

@birdofpreyru
Copy link
Collaborator

@lijulat Yeap, as it was never mentioned to remove it, I guess Google.Analytics should stay.

@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru PR 471 on the TC-site repo

@birdofpreyru
Copy link
Collaborator

@lijulat Ok, will check it later.
Don't forget that we also need to remove them from the code in this repo as well.

@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru PR coming your way :) . Can i delete the js file or should i keep the js file and remove the contents? . Just asking ,because kissmetrics the js file is present with no contents still in this repo,

@birdofpreyru
Copy link
Collaborator

@lijulat Please remove them completely, just double check that nothing else refer to them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants