Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

[$20+$10] - Sitemap, About Us, Contact Us, etc. links in the narrow screen view #967

Closed
birdofpreyru opened this issue Jan 29, 2017 · 8 comments
Assignees

Comments

@birdofpreyru
Copy link
Collaborator

Look at the footer when the site is open in a wide window:
scr-1

Now, look at the footer when the site is open in a narrow window:
scr-2

You see, that the links Sitemap, About Us, Contact Us, ... are missing, also the social network icons are grey in the narrow view vs. colored in the wide view, and also the copyright line is gray in the narrow screen, while wide in the wide screen.

All this should be fixed in the narrow-screen view to be consistent with the wide-screen view, to look like this (sure, the spacings between the elements should be nice and equal, excuse my poor drawing skills):
scr-3

This issue should be fixed both in this repo, and in the https://github.com/appirio-tech/tc-site
I believe, this is a purely CSS fix, as the relevant links are present in the HTML markup, just not shown in the narrow-size window

@ThomasKranitsas
Copy link
Contributor

@birdofpreyru I'll work on this one :)

@birdofpreyru
Copy link
Collaborator Author

@ThomasKranitsas This needs the following changes:

  1. Remove the OTHERS title, and ensure there is a bit larger padding between the top of the footer and the first link (SITEMAP).
  2. Make the color of these footer links white (the same white as in the wide-screen view), and blue when hovered.
  3. Decrease the spacing between social icons and (C) 2016 Topcoder. All Rights Reserved. Like twice smaller.

Also add similar changes into this repo,

@birdofpreyru
Copy link
Collaborator Author

@ThomasKranitsas Any update?

@ThomasKranitsas
Copy link
Contributor

I'll submit PR later today. sorry for delay

@ajefts ajefts removed the in progress label Feb 2, 2017
@birdofpreyru birdofpreyru reopened this Feb 2, 2017
@birdofpreyru birdofpreyru changed the title [$10] - Sitemap, About Us, Contact Us, etc. links in the narrow screen view [$20] - Sitemap, About Us, Contact Us, etc. links in the narrow screen view Feb 2, 2017
@ThomasKranitsas ThomasKranitsas removed their assignment Feb 4, 2017
@lijulat lijulat self-assigned this Feb 4, 2017
@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru Is there anythign pending on this ticket?

@birdofpreyru
Copy link
Collaborator Author

@lijulat Yes, check the comments in this PR: #978
It almost does what is necessary, but breaks the build, and it should be fixed

I believe, what @ThomasKranitsas did already, cost $20.
So, I'd say fixing the last small issues will cost $10, what do you think?

@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru let me give me it a try.

@lijulat
Copy link
Contributor

lijulat commented Feb 4, 2017

@birdofpreyru I have updated the PR . Please check and let me know.

@birdofpreyru birdofpreyru changed the title [$20] - Sitemap, About Us, Contact Us, etc. links in the narrow screen view [$20+$10] - Sitemap, About Us, Contact Us, etc. links in the narrow screen view Feb 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants