Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

[$30] - Challenge details page needs some enhancements in its CSS styling #938

Closed
birdofpreyru opened this issue Jan 20, 2017 · 8 comments
Closed
Assignees

Comments

@birdofpreyru
Copy link
Collaborator

birdofpreyru commented Jan 20, 2017

Expected Fix:

  1. Have a look at this sample challenge page: https://www.topcoder.com/challenge-details/30056243/?type=develop&noncache=true
    We need some corrections in CSS to make it look more pretty, than it is now.
    1. Spaces between headers and paragraphs should be corrected. The space between any header and the following paragraph should be equal to the current spacing between two paragraphs. The space before any header and the preceding paragraph should be larger than that.
    2. For H1 header please set the same style, as H2 header uses now. Keep H2 header the same as now. For H3 header increase the font size to match the size of text in the paragraphs. For H4-H6 paragraphs, reuse the same style as for H3, but with black text color.
    3. As you'll see in the end of the challenge overview section, italic text looks twice smaller than the regular text around it. Should be the same size.
    4. The header Final Submission Guidelines should H2 header.
    5. Headers in the Final Submission Guidelines section should be the same style as in the Challenge Overview.
    6. As you'll see, in the Final Submission Guidelines section, paragraph text has different style, depending whether it is wrapped inside <p> tag (then it looks the same like in the Challenge Overview) or not (the it is bolder and smaller). Please make it looks the same in both cases, as it looks now without the <p> tag (i.e. the bolder version).
  2. To test it locally, you'll have to locally deploy this code: https://github.com/appirio-tech/tc-site Once setup it will work with the production database, so you'll be able to access this sample challenge from your locally deployed frontend, and to see the changes you are performing.
@birdofpreyru birdofpreyru changed the title [$40] - Challenge details page needs some enhancements in its CSS styling [$30] - Challenge details page needs some enhancements in its CSS styling Jan 23, 2017
@ThomasKranitsas
Copy link
Contributor

@birdofpreyru Can you add me on this one? Thanks!

@birdofpreyru
Copy link
Collaborator Author

@ThomasKranitsas Ok, it is yours.

@ThomasKranitsas
Copy link
Contributor

So the PR for this will be against the https://github.com/appirio-tech/tc-site repo and I'll just mention this ticket there, correct?

@birdofpreyru
Copy link
Collaborator Author

@ThomasKranitsas Sure, all PR against the corresponding repos, just reference them from the original issue tickets, so that nothing is lost.

@birdofpreyru
Copy link
Collaborator Author

birdofpreyru commented Jan 26, 2017

@ThomasKranitsas Any update on this? Are working on it?

@ThomasKranitsas
Copy link
Contributor

Hey @birdofpreyru! Sorry for the delay.. I'll submit PR in the next few hours

@birdofpreyru
Copy link
Collaborator Author

@ThomasKranitsas No worries, no need to hurry. Just checking that you have not forgot about it :)

@ThomasKranitsas
Copy link
Contributor

@birdofpreyru I submitted a PR here: topcoder-archive/appirio_tech-tc-site#462

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants