SUP-2387, Dealing with stats for design and non-rated sub-tracks

-- Showed the statistics tab for non rated tracks (design specifically)

Author: vikasrohit

app/profile/about/about.jade

@@ -67,13 +67,13 @@
             )
               .name {{subtrack.subTrack | track}}
 
-              .ranking(ng-if="subtrack.rating")
+              .ranking(ng-if="subtrack.statType == 'Rating'")
                 .number.rating(style="color: {{subtrack.rating | ratingColor}}")
                   | {{subtrack.rating}}
 
                 .tag Rating
 
-              .ranking(ng-if="subtrack.rank && !subtrack.rating")
+              .ranking(ng-if="subtrack.statType == 'Ranking'")
                 .number {{subtrack.rank | ordinal}}
 
                 .tag Ranking

app/profile/subtrack/design/design-statistics.jade

@@ -0,0 +1,33 @@
+.design(ng-if="vm.track == 'DESIGN'")
+
+  .bottom
+    h2.detailed Details
+
+    ul.vertical-stats
+      li.first
+        .left Win Percentage
+        .right {{vm.typeStats.winPercent | percentage | empty}}
+
+      li(ng-if="profileVm.isUser")
+        .left Inquiries
+        .right {{vm.typeStats.numInquiries | empty}}
+
+      li(ng-if="profileVm.isUser")
+        .left Submissions
+        .right {{vm.typeStats.submissions | empty}}
+
+      li
+        .left Submission Rate
+        .right {{vm.typeStats.submissionRate | percentage | empty}}
+
+      li.first(ng-if="profileVm.isUser")
+        .left Passed Screening
+        .right {{vm.typeStats.passedScreening | empty}}
+
+      li
+        .left Screening Success Rate
+        .right {{vm.typeStats.screeningSuccessRate | percentage | empty}}
+
+      li
+        .left Average Placement
+        .right {{vm.typeStats.avgPlacement | number: 2 | empty}}

app/profile/subtrack/subtrack.controller.js

@@ -28,9 +28,7 @@
     vm.pageName = vm.subTrack.toLowerCase().replace(/_/g, ' ');
 
     vm.tabs = [];
-    if (vm.track !== 'DESIGN') {
-      vm.tabs.push('statistics');
-    }
+    vm.tabs.push('statistics');
 
     if (vm.track !== 'COPILOT') {
       vm.tabs.push( vm.subTrack === 'SRM' ? 'Past srm': 'challenges');

app/profile/subtrack/subtrack.jade

@@ -20,11 +20,10 @@
                 p.label {{item.label}}
 
         include ./develop/develop-statistics.jade
-        //- yes, challenges :( this is confusing and needs refactoring
-        include ./design/design-challenges.jade
+        include ./design/design-statistics.jade
         include ./data/data-statistics.jade
 
-      tc-tab(heading="{{vm.tabs[1]}}", ng-if="vm.track === 'DATA_SCIENCE' || vm.track === 'DEVELOP'")
+      tc-tab(heading="{{vm.tabs[1]}}")
         .subtrack-stats
           responsive-carousel(data="vm.subTrackStats", handle="{{vm.handle}}")
             .carousel-elem
@@ -37,5 +36,6 @@
                 p.value(ng-hide="item.label === 'rating'") {{item.val | empty}}
 
                 p.label {{item.label}}
-        include ./develop/develop-challenges.jade        
+        include ./develop/develop-challenges.jade    
+        include ./design/design-challenges.jade    
         include ./data/data-challenges.jade

assets/css/profile/subtrack.scss

@@ -527,6 +527,13 @@
       }
 
     }
+
+    .design {
+      // override height of the statistics section for design track as we don't have limited stats for design
+      ul.vertical-stats {
+        height: 200px;
+      }
+    }
   }
   }
   .categoryNav {