Cleanup

Author: tladendo

app/directives/srm-tile/srm-tile.directive.jade

@@ -3,7 +3,7 @@
     .challenge-track
 
     header
-      a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{srm.rounds[0].id}}") {{srm.name}}
+      a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{roundId}}") {{srm.name}}
 
     .srm-details
       p.starts-in Starts in #[span {{srm.codingStartAt | timeDiff:"quantity"}} {{srm.codingStartAt | timeDiff:'unit'}}]
@@ -17,22 +17,22 @@
     .phase-status
       .registered(ng-show="srm.userStatus === CONSTANTS.REGISTERED") Registered
       .unregistered(ng-hide="srm.currentPhase !== CONSTANTS.REGISTRATION || srm.userStatus === CONSTANTS.REGISTERED")
-        a.tc-btn.tc-btn-s.tc-btn-wide(href="https://community.{{DOMAIN}}/tc?module=MatchDetails&rd={{srm.rounds[0].id}}") Register
+        a.tc-btn.tc-btn-s.tc-btn-wide(href="https://community.{{DOMAIN}}/tc?module=MatchDetails&rd={{roundId}}") Register
 
   .past-srm(ng-show="srm.status === 'PAST'")
     .challenge-track
 
     header
-      a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{srm.rounds[0].id}}") {{srm.name}}
+      a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{roundId}}") {{srm.name}}
       .ended-on #[span {{srm.codingEndAt | localTime:"MMM DD, YYYY" }}]
 
     .member-stats
       p.points #[span {{srm.result.finalPoints }}] #[span Points]
       .ranks
-        a.division(href="https://community.{{DOMAIN}}/stat?c=round_stats&rd={{srm.rounds[0].id}}&dn={{srm.result.division}}")
+        a.division(href="https://community.{{DOMAIN}}/stat?c=round_stats&rd={{roundId}}&dn={{division}}")
           p.rank {{srm.result.divisionPlacement}}
           p.label  #[span Division {{srm.result.division}}]
-        a.room(href="https://community.{{DOMAIN}}/stat?c=coder_room_stats&cr={{userId}}&rd={{srm.rounds[0].id}}")
+        a.room(href="https://community.{{DOMAIN}}/stat?c=coder_room_stats&cr={{userId}}&rd={{roundId}}")
           p.rank #[span {{srm.result.roomPlacement}}]
           p.label #[span Room] 
       p.placement Placement
@@ -42,21 +42,21 @@
     .challenge-track
     header
       .srm-name
-        a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{srm.rounds[0].id}}") {{srm.name}}
+        a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{roundId}}") {{srm.name}}
 
     .srm-details
       p.starts-in Starts in #[span {{srm.codingStartAt | timeDiff:"quantity"}} {{srm.codingStartAt | timeDiff:'unit'}}]
 
     .phase-status
       .registered(ng-show="srm.userStatus === CONSTANTS.REGISTERED") Registered
       .unregistered(ng-hide="srm.currentPhase !== CONSTANTS.REGISTRATION || srm.userStatus === CONSTANTS.REGISTERED")
-        a.tc-btn.tc-btn-s.tc-btn-wide(href="https://community.{{DOMAIN}}/tc?module=MatchDetails&rd={{srm.rounds[0].id}}") Register
+        a.tc-btn.tc-btn-s.tc-btn-wide(href="https://community.{{DOMAIN}}/tc?module=MatchDetails&rd={{roundId}}") Register
 
   .past-srm(ng-show="srm.status === 'PAST'")
     .challenge-track
     header
       .srm-name
-        a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{srm.rounds[0].id}}") {{srm.name}}
+        a(ng-href="https://community.{{DOMAIN}}/stat?c=round_overview&rd={{roundId}}") {{srm.name}}
 
     .srm-details
       p.ended-on Ended {{srm.codingEndAt | timeDiff:"quantity"}} {{srm.codingEndAt | timeDiff:'unit'}} ago
@@ -65,10 +65,10 @@
       p.points #[span {{srm.result.finalPoints }}] Points
 
       .ranks
-        a.division(ng-class="{noclick: !srm.result.divisionPlacement}")
+        a.division(ng-class="{noclick: !srm.result.divisionPlacement}", href="https://community.{{DOMAIN}}/stat?c=round_stats&rd={{roundId}}&dn={{division}}")
           p.rank {{srm.result.divisionPlacement}}
           p.label #[span Div {{srm.result.division}}] #[span Placement]
-        a.room(ng-class="{noclick: !srm.result.roomPlacement}")
+        a.room(ng-class="{noclick: !srm.result.roomPlacement}", href="https://community.{{DOMAIN}}/stat?c=coder_room_stats&cr={{userId}}&rd={{roundId}}")
           p.rank #[span {{srm.result.roomPlacement}}]
           p.label #[span Room] #[span Placement]
 

app/directives/srm-tile/srm-tile.directive.js

@@ -13,10 +13,12 @@
       },
       controller: ['$scope', '$filter', 'CONSTANTS', 'SRMService',
         function($scope, $filter, CONSTANTS, SRMService) {
-        $scope.DOMAIN = CONSTANTS.domain;
-        $scope.CONSTANTS = CONSTANTS;
-        $scope.srm.userStatus = _.get($scope.srm, 'userStatus', null);
-        SRMService.processSRM($scope.srm);
+          $scope.DOMAIN = CONSTANTS.domain;
+          $scope.CONSTANTS = CONSTANTS;
+          $scope.srm.userStatus = _.get($scope.srm, 'userStatus', null);
+          SRMService.processSRM($scope.srm);
+          $scope.roundId = $scope.srm.rounds.length && $scope.srm.rounds[0].id;
+          $scope.division = $scope.srm.result && $scope.srm.result.division;
       }]
     };
   });