Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit f0399e1

Browse files
author
vikasrohit
committed
SUP-2582, Upcoming SRMs should be ordered by most recent date
-- Incorporated code review comments
1 parent 5809bd3 commit f0399e1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

app/my-dashboard/srms/srms.controller.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121

2222
function getSRMs() {
2323
var params = {
24-
filter: 'status=future&orderBy=registrationStartAt',
24+
filter: 'status=future',
25+
orderBy: 'registrationStartAt',
2526
limit: 3
2627
};
2728

app/my-srms/my-srms.controller.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252

5353
function changeFilter(filter) {
5454
vm.statusFilter = filter;
55+
// for upcoming SRMs sorting is done ascending order of codingStartAt
56+
// for past SRMs sorting is done descending order of codingEndAt
5557
vm.orderBy = filter === 'future'? 'codingStartAt': 'codingEndAt';
5658
vm.reverseOrder = filter !== 'future';
5759
// update url but don't reload

0 commit comments

Comments
 (0)