Form

Author: Nick Litwin

app/submissions/submissions.controller.js

@@ -10,8 +10,6 @@
 
     activate();
 
-    function activate() {
-      vm.testValue = 'testValue';
-    }
+    function activate() {}
   }
 })();

app/submissions/submissions.spec.js

@@ -19,6 +19,5 @@ describe('Submissions Controller', function() {
 
   it('should exist', function() {
     expect(vm).to.exist;
-    expect(vm.testValue).to.equal('testValue');
   });
 });

app/submissions/submit-file/submit-file.controller.js

@@ -41,9 +41,7 @@
 
     activate();
 
-    function activate() {
-
-    }
+    function activate() {}
 
     function setFileReference(file, fieldId) {
       var fileObject = {
@@ -63,7 +61,7 @@
           fileObject.mediaType = file.type;
       }
 
-      // If user picks a new file, replace the fileObject with the new one
+      // If user picks a new file, replace the that file's fileObject with a new one
       // Or add it the list if it's not there
       if (vm.submissionsBody.data.files.length) {
         vm.submissionsBody.data.files.some(function(file, i, filesArray) {

app/submissions/submit-file/submit-file.jade

@@ -6,18 +6,18 @@
 
     a Learn more about formatting your submission file
 
-    a.tc-btn.tc-btn-s Back to Challenge Details
+    a.tc-btn.tc-btn-s(ng-click="'TODO: go back to challenge details'") Back to Challenge Details
 
 .panel-body
-  .form-blocks
+  form.form-blocks(name="vm.submissionForm", role="form", ng-submit="vm.submissionForm.$valid && vm.uploadSubmission()", novalidate)
     .form-block.flex.wrap
       .form-block__instructions
         .form-block__title Files
 
         .form-block__text
           p Please follow the instructions on the Challenge Details page regarding what your submission, source, and preview files should contain.
 
-          p Do not name any of your files "declaration.txt" as this is added by our system.
+          p Do not name any of your files "declaration.txt", as this is added by our system.
 
           p Please be sure to double-check that you have submitted the correct files and that your JPG files (if applicable) are in RGB color mode.
 
@@ -114,8 +114,8 @@
     p Submitting your files means you hereby agree to the #[a(href="https://www.{{DOMAIN}}/community/how-it-works/terms/", target="_blank") Topcoder terms of use] and to the extent your uploaded file wins a Topcoder Competition, you hereby assign, grant, and transfer to Topcoder all rights in and title to the Winning Submission (as further described in the terms of use).
 
     .checkbox.flex.center
-      input(type="checkbox", ng-model="vm.hasAgreedToTerms")
+      input(type="checkbox", ng-model="vm.hasAgreedToTerms", id="agree-to-terms", required)
 
-      label I understand and agree
+      label(for="agree-to-terms") I understand and agree
 
-    button.tc-btn.tc-btn-secondary(ng-click="vm.uploadSubmission()") Submit
+    button.tc-btn.tc-btn-secondary(type="submit", ng-disabled="vm.submissionForm.$invalid") Submit