Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit de42c06

Browse files
author
vikasrohit
committed
AS#118090147171048, Mail chimp Integration
-- Fixed delay in loading Email tab
1 parent c743981 commit de42c06

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

app/settings/email/email.controller.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import angular from 'angular'
55

66
angular.module('tc.settings').controller('EmailSettingsController', EmailSettingsController)
77

8-
EmailSettingsController.$inject = ['$rootScope', 'userProfile', 'ProfileService', 'MailchimpService', 'logger', 'CONSTANTS', 'toaster', '$q', '$scope']
8+
EmailSettingsController.$inject = ['$rootScope', 'userData', 'ProfileService', 'MailchimpService', 'logger', 'CONSTANTS', 'toaster', '$q', '$scope']
99

10-
function EmailSettingsController($rootScope, userProfile, ProfileService, MailchimpService, logger, CONSTANTS, toaster, $q, $scope) {
10+
function EmailSettingsController($rootScope, userData, ProfileService, MailchimpService, logger, CONSTANTS, toaster, $q, $scope) {
1111
var vm = this
1212
vm.loading = false
1313
vm.saving = false
@@ -63,11 +63,11 @@ import angular from 'angular'
6363
]
6464

6565
vm.loading = true
66-
return MailchimpService.getMemberSubscription(userProfile).then(function(subscription) {
66+
return MailchimpService.getMemberSubscription(userData).then(function(subscription) {
6767
vm.loading = false
6868
if (!subscription) {
69-
// add member to the list with empty preferences
70-
MailchimpService.addSubscription(userProfile, {}).then(function(resp) {
69+
// add member to the list with default preferences
70+
MailchimpService.addSubscription(userData, {}).then(function(resp) {
7171
logger.debug(resp)
7272
}).catch(function(err) {
7373
// no error to user
@@ -102,7 +102,7 @@ import angular from 'angular'
102102
vm.newsletters.forEach(function(newsletter) {
103103
preferences[newsletter.id] = newsletter.enabled
104104
})
105-
MailchimpService.addSubscription(userProfile, preferences).then(function(resp) {
105+
MailchimpService.addSubscription(userData, preferences).then(function(resp) {
106106
vm.loading = false
107107
vm.saving = false
108108
// reset dirty state for all newsletter options

app/settings/settings.routes.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,6 @@ import angular from 'angular'
5454
controllerAs: 'vm',
5555
data: {
5656
title: 'Email Preferences'
57-
},
58-
resolve: {
59-
userIdentity: ['UserService', function(UserService) {
60-
return UserService.getUserIdentity()
61-
}],
62-
userProfile: ['userIdentity', 'ProfileService', function(userIdentity, ProfileService) {
63-
return ProfileService.getUserProfile(userIdentity.handle.toLowerCase())
64-
}]
6557
}
6658
},
6759
'settings.preferences': {

0 commit comments

Comments
 (0)