Merge pull request #593 from appirio-tech/qa-integration

Qa integration

Author: tladendo

.version

@@ -1 +1 @@
-v1.0.16
+v1.0.17

app/account/login/login.controller.js

@@ -3,96 +3,116 @@
 
   angular.module('tc.account').controller('LoginController', LoginController);
 
-  LoginController.$inject = ['$log', '$state', '$stateParams', '$location', '$scope', 'TcAuthService', 'AuthTokenService', 'UserService', 'NotificationService', 'Helpers', 'CONSTANTS'];
+  LoginController.$inject = ['$log', '$state', '$stateParams', '$location', '$scope', 'TcAuthService', 'UserService', 'NotificationService', 'Helpers', 'CONSTANTS'];
 
-  function LoginController($log, $state, $stateParams, $location, $scope, TcAuthService, AuthTokenService, UserService, NotificationService, Helpers, CONSTANTS) {
-    $log = $log.getInstance("LoginController");
+  function LoginController($log, $state, $stateParams, $location, $scope, TcAuthService, UserService, NotificationService, Helpers, CONSTANTS) {
     var vm = this;
+    $log = $log.getInstance("LoginController");
     vm.$stateParams = $stateParams;
     vm.passwordReset = false;
-    vm.usernameExists = true;
     vm.currentPasswordDefaultPlaceholder = "Password";
+    vm.loginErrors = {
+      USERNAME_NONEXISTANT: false,
+      WRONG_PASSWORD: false,
+      SOCIAL_LOGIN_ERROR: false
+    };
+
+    vm.login = login;
+    vm.socialLogin = socialLogin;
+
     // reference for main vm
     var mainVm = $scope.$parent.main;
 
-    if ($stateParams.notifyReset) {
-      NotificationService.inform('Your new password has been set. Please log in. If you have any trouble, please contact [email protected].');
-    }
+    activate();
 
-    function _doLogin(usernameOrEmail, password) {
-     return TcAuthService.login(usernameOrEmail, password).then(
-      function(data) {
-        // success
-        $log.debug('logged in');
-        // setup login event for analytics tracking
-        Helpers.setupLoginEventMetrices(usernameOrEmail);
-        return Helpers.redirectPostLogin($stateParams.next);
-      })
-     .catch(function(resp) {
-        $log.warn(resp);
-        switch (resp.status) {
-          case "ACCOUNT_INACTIVE":
-            $state.go('registeredSuccessfully');
-            // user should already be redirected
-            break;
-          case "UNKNOWN_ERROR":
-          default:
-            vm.wrongPassword = true;
-            vm.password = '';
-        }
-      });
+    function activate() {
+      if ($stateParams.notifyReset) {
+        NotificationService.inform('Your new password has been set. Please log in. If you have any trouble, please contact [email protected].');
+      }
     }
 
-    vm.login = function() {
-      vm.usernameExists = true;
-      vm.wrongPassword = false;
+    function login() {
+      vm.loginErrors.USERNAME_NONEXISTANT = false;
+      vm.loginErrors.WRONG_PASSWORD = false;
+
       // TODO ideally it should be done by dedicated directive to handle all outside clicks
       mainVm.menuVisible = false;
 
       if (Helpers.isEmail(vm.username)) {
+        // the user is loggin in using email
         vm.emailOrUsername = 'email';
+
         // ensure email exists
+        // uses same validity check as registration
+        // valid => email isn't already used by someone
         UserService.validateUserEmail(vm.username).then(function(data) {
           if (data.valid) {
             // email doesn't exist
-            vm.usernameExists = false;
+            vm.loginErrors.USERNAME_NONEXISTANT = true;
           } else {
-            vm.usernameExists = true;
             _doLogin(vm.username, vm.currentPassword);
           }
         }).catch(function(resp) {
           // TODO handle error
           // assume email exists, login would in any case if it didn't
-          vm.usernameExists = true;
+          vm.loginErrors.USERNAME_NONEXISTANT = false;
           _doLogin(vm.username, vm.currentPassword);
         });
       } else {
+        // the user is logging in using a username
         vm.emailOrUsername = 'username';
+
         // username - make sure it exists
         UserService.validateUserHandle(vm.username).then(function(data) {
           if (data.valid) {
             // username doesn't exist
-            vm.usernameExists = false;
+            vm.loginErrors.USERNAME_NONEXISTANT = true;
           } else {
-            vm.usernameExists = true;
             _doLogin(vm.username, vm.currentPassword);
           }
         }).catch(function(resp) {
           // TODO handle error
           // assume email exists, login would in any case if it didn't
-          vm.usernameExists = true;
           _doLogin(vm.username, vm.currentPassword);
         });
       }
     };
 
-    vm.socialLogin = function(backend) {
-      var params = {}, callbackUrl;
+    function _doLogin(usernameOrEmail, password) {
+      return TcAuthService.login(usernameOrEmail, password).then(function(data) {
+        // success
+        $log.debug('logged in');
+
+        // setup login event for analytics tracking
+        Helpers.setupLoginEventMetrics(usernameOrEmail);
+        return Helpers.redirectPostLogin($stateParams.next);
+
+      }).catch(function(resp) {
+        $log.warn(resp);
+        switch (resp.status) {
+          case "ACCOUNT_INACTIVE":
+            $state.go('registeredSuccessfully');
+            // user should already be redirected
+            break;
+          case "UNKNOWN_ERROR":
+          default:
+            vm.loginErrors.WRONG_PASSWORD = true;
+            vm.password = '';
+        }
+      });
+    }
+
+    function socialLogin(platform) {
+      // we need to pass on the 'next' param if we have one
+      var params = {};
       if ($stateParams.next) {
         params = {next: $stateParams.next};
       }
-      callbackUrl = $state.href('login', params, {absolute: true});
-      TcAuthService.socialLogin(backend, callbackUrl)
+
+      // redirect back to login
+      var callbackUrl = $state.href('login', params, {absolute: true});
+
+      TcAuthService.socialLogin(platform, callbackUrl)
       .then(function() {
         $log.debug('logged in');
         return Helpers.redirectPostLogin($stateParams.next);
@@ -104,6 +124,7 @@
           case "USER_NOT_REGISTERED":
           default:
             vm.socialLoginError = 401;
+            vm.loginErrors.SOCIAL_LOGIN_ERROR = true;
             break;
         }
       });

app/account/login/login.jade

@@ -6,14 +6,14 @@
   h1 LOG IN TO TOPCODER
 
   form(name="vm.loginForm", role="form", ng-submit="vm.loginForm.$valid && vm.login()", novalidate)
-    .form-errors
-      p.form-error(ng-hide="vm.usernameExists") We couldn't find a member with that {{vm.emailOrUsername || "username"}}. Please check that you entered it correctly.
+    .form-errors(ng-messages="vm.loginErrors")
+      p.form-error(ng-message="USERNAME_NONEXISTANT") We couldn't find a member with that {{vm.emailOrUsername || "username"}}. Please check that you entered it correctly.
 
-      p.form-error(ng-show="vm.wrongPassword") That password is incorrect. Please check that you entered the right one.
+      p.form-error(ng-message="WRONG_PASSWORD") That password is incorrect. Please check that you entered the right one.
 
-      p.form-error(ng-show="vm.socialLoginError === 401") User with that profile is not registered.
+      p.form-error(ng-message="SOCIAL_LOGIN_ERROR") User with that profile is not registered.
 
-    div.validation-bar(ng-class="{'error-bar': !vm.usernameExists}")
+    div.validation-bar(ng-class="{'error-bar': vm.loginErrors.USERNAME_NONEXISTANT}")
       input(ng-model="vm.username", name="username", placeholder="Username or Email", type="text", required)
 
     toggle-password

app/directives/account/toggle-password/toggle-password.directive.js

@@ -40,6 +40,7 @@
           if (relatedTarget.attr('type') === 'checkbox' && relatedTarget.attr('id') === 'currentPasswordCheckbox') {
             vm.currentPasswordFocus = true;
             vm.currentPasswordPlaceholder = '';
+            currentPasswordInput.focus();
           } else {
             // If you are blurring from the password input and clicking anywhere but the checkbox
             vm.currentPasswordFocus = false;

app/directives/account/toggle-password/toggle-password.jade

@@ -2,7 +2,6 @@ input#current-password-input(
   ng-model="vm.currentPassword",
   ng-model-options="{allowInvalid: true}",
 
-  focus-on="focusOnCurrentPasswordInput",
   ng-focus="vm.onCPFocus($event)",
   ng-blur="vm.onCPBlur($event)",
 

app/directives/badges/badge-tooltip.spec.js

@@ -1,5 +1,5 @@
 /* jshint -W117, -W030 */
-describe('Badge Tooltiop Directive', function() {
+describe('Badge Tooltip Directive', function() {
   var scope;
   var element;
   var badge = mockData.getMockBadge();

app/directives/challenge-tile/challenge-tile.directive.jade

@@ -32,7 +32,8 @@
     // Only show if not data science track
     p.roles 
       span(ng-hide="challenge.track === 'DATA_SCIENCE'") 
-       #[span Role: ] #[span {{challenge.userDetails.roles | listRoles}}]
+        span Role:  
+        span {{challenge.userDetails.roles | listRoles}}
 
   .completed-challenge(
     ng-show="challenge.status === 'COMPLETED' || challenge.status === 'PAST'",
@@ -66,7 +67,8 @@
     // Only show if not data science track
     p.roles
       span(ng-hide="challenge.track === 'DATA_SCIENCE'") 
-        #[span Role: ] #[span {{challenge.userDetails.roles | listRoles}}]
+        span Role:  
+        span {{challenge.userDetails.roles | listRoles}}
 
 .challenge.list-view(ng-show="view=='list'", ng-class="challenge.track")
   .active-challenge(ng-show="challenge.status === 'ACTIVE'")

app/directives/distribution-graph/distribution-graph.directive.js

@@ -178,18 +178,31 @@
          })
          .attr('fill', function(d) {
            return ratingToColor($scope.colors, d.start);
+         });
+
+      svg.selectAll('rect.hover')
+         .data(ranges)
+         .enter()
+         .append('rect')
+         .attr('class', 'hover')
+         .attr('fill', 'transparent')
+         .attr('x', function(d, i) {
+           return xScale(i);
+         })
+         .attr('y', function(d) {
+           return padding.top;
+         })
+         .attr('width', xScale.rangeBand())
+         .attr('height', function(d) {
+           return totalH - padding.bottom - padding.top;
          })
          .on('mouseover', function(d) {
-           d3.select(this)
-             .attr('fill', ratingToDarkerColor($scope.colors, d.start));
            $scope.highlightedRating = d.start;
            $scope.displayCoders = true;
            $scope.numCoders = d.number;
            $scope.$digest();
          })
          .on('mouseout', function(d) {
-           d3.select(this)
-             .attr('fill', ratingToColor($scope.colors, d.start));
            $scope.displayCoders = false;
            $scope.highlightedRating = false;
            $scope.$digest();