fixed broken tests

Author: tladendo

app/profile/subtrack/subtrack.controller.js

@@ -43,8 +43,10 @@
       var historyDeferred = $q.defer();
       vm.historyPromise = historyDeferred.promise;
       ProfileService.getHistoryStats(profileVm.profile.handle).then(function(data) {
-        vm.history = ProfileService.getChallengeTypeStats(data, vm.track, vm.subTrack).history;
-        historyDeferred.resolve(vm.history);
+        if (data.handle) {
+          vm.history = ProfileService.getChallengeTypeStats(data, vm.track, vm.subTrack).history;
+          historyDeferred.resolve(vm.history);
+        }
       });
       profileVm.statsPromise.then(function(data) {
         vm.typeStats = ProfileService.getChallengeTypeStats(

app/profile/subtrack/subtrack.spec.js

@@ -6,6 +6,7 @@ describe('SubTrack Controller', function() {
   var mockStats = mockData.getMockStats();
   var mockSkills = mockData.getMockSkills();
   var mockChallenges = mockData.getMockiOSChallenges();
+  var mockHistory = mockData.getMockHistory();
   var apiUrl;
   var track = 'develop', subTrack = 'development';
   var profileScope, scope;
@@ -57,6 +58,10 @@ describe('SubTrack Controller', function() {
       .when('GET', apiUrl + '/members/rakesh/stats/')
       .respond(200, {result: {content: mockStats}});
     // mock skills
+    $httpBackend
+      .when('GET', apiUrl + '/members/albertwang/stats/history/')
+      .respond(200, mockHistory);
+    // mock history
     $httpBackend
       .when('GET', apiUrl + '/members/rakesh/skills/')
       .respond(200, {result: {content: mockSkills}});
@@ -67,6 +72,13 @@ describe('SubTrack Controller', function() {
       deferred.resolve(resp);
       return deferred.promise;
     });
+
+    sinon.stub(profileService, 'getHistoryStats', function(handle) {
+      var deferred = $q.defer();
+      var resp = {};
+      deferred.resolve(resp);
+      return deferred.promise;
+    });
   });
 
   afterEach(function() {

app/settings/update-password/update-password.spec.js

@@ -12,6 +12,10 @@ describe('Update Password Controller', function() {
     };
 
     vm = $controller('UpdatePasswordController', {
+      userData: {
+        handle: 'foo',
+        email: 'bar'
+      },
       UserService: {
         getUserIdentity: function() {
           return {

app/skill-picker/skill-picker.spec.js

@@ -3,11 +3,10 @@ describe('Skill Picker Controller', function() {
   var vm;
 
   beforeEach(function() {
-    bard.appModule('tc.settings');
+    bard.appModule('tc.skill-picker');
     bard.inject(this, '$controller', '$rootScope', '$q');
 
     vm = $controller('SkillPickerController', {
-      userData: userData
     });
   });
 
@@ -17,8 +16,4 @@ describe('Skill Picker Controller', function() {
     expect(vm).to.exist;
   });
 
-  describe('user data', function() {
-
-  });
-
 });

tests/test-helpers/mock-data.js

@@ -14,6 +14,7 @@ var mockData = (function() {
     getMockUserProfile: getMockUserProfile,
     getMockMarathons: getMockMarathons,
     getMockProfile: getMockProfile,
+    getMockHistory: getMockHistory,
     getMockStats: getMockStats,
     getMockSkills: getMockSkills,
     getMockSRMs: getMockSRMs,
@@ -1291,6 +1292,68 @@ var mockData = (function() {
     };
   }
 
+  function getMockHistory() {
+    return {
+      "id": "-306aafb8:14f65e30765:-8000",
+      "result": {
+        "success": true,
+        "status": 200,
+        "metadata": null,
+        "content": {
+          "updatedAt": null,
+          "createdAt": null,
+          "createdBy": null,
+          "updatedBy": null,
+          "userId": 151743,
+          "handle": "Ghostar",
+          "DEVELOP": {
+            "subTracks": [
+              {
+                "id": 112,
+                "name": "DESIGN",
+                "history": [
+                  {
+                    "challengeId": 30009817,
+                    "challengeName": "Disney Marine Munch - Flash Game Module Architecture",
+                    "ratingDate": "2010-02-28T13:00:00.000Z",
+                    "newRating": 1172
+                  }
+                ]
+              },
+              {
+                "id": 125,
+                "name": "ASSEMBLY_COMPETITION",
+                "history": [
+                  {
+                    "challengeId": 30007872,
+                    "challengeName": "Best Buy Blackberry Web Application Wrapper Assembly",
+                    "ratingDate": "2009-10-18T23:30:00.000Z",
+                    "newRating": 1515
+                  },
+                  {
+                    "challengeId": 30008010,
+                    "challengeName": "Best Buy Android Web Application Wrapper Assembly",
+                    "ratingDate": "2009-10-24T01:00:00.000Z",
+                    "newRating": 1566
+                  }
+                ]
+              }
+            ]
+          },
+          "DATA_SCIENCE": {
+            "SRM": {
+              "history": []
+            },
+            "MARATHON_MATCH": {
+              "history": []
+            }
+          }
+        }
+      },
+      "version": "v3"
+    }
+  }
+
   function getMockStats() {
     return {
       "updatedAt": null,