more fixes

Author: Parth Shah

app/peer-review/completed-review/completed-review.controller.js

@@ -25,41 +25,34 @@
 
     function activate() {
       var promises = [
-        handle,
         ChallengeService.getChallengeDetails($stateParams.challengeId),
         ReviewService.getReview($stateParams.reviewId),
         ScorecardService.getScorecard(vm.challengeId)
       ];
 
       $q.all(promises)
-      .then(function(response) {
-        var user = response[0].data;
+      .then(function(responses) {
         vm.stats.username = handle;
 
-        var challenge = response[1].data;
-        vm.challenge = challenge;
+        vm.challenge = responses[0];
 
-        var reviewData = response[2].data.result.content;
-        vm.review = reviewData;
-        vm.stats.submissionId = reviewData.submissionId;
-        vm.stats.uploadId = reviewData.uploadId;
-        vm.stats.createdAt = reviewData.createdAt;
-        vm.stats.updatedAt = reviewData.updatedAt;
+        vm.review = responses[1];
+        vm.stats.submissionId = vm.review.submissionId;
+        vm.stats.uploadId = vm.review.uploadId;
+        vm.stats.createdAt = vm.review.createdAt;
+        vm.stats.updatedAt = vm.review.updatedAt;
 
-        var scorecardData = response[3].data.result.content[0];
+        var scorecardData = responses[2][0];
         var scorecardId = scorecardData.id;
 
         ScorecardService.getScorecardQuestions(scorecardId)
-        .then(function(data) {
-          var questions = data.data.result.content;
-
+        .then(function(questions) {
           Helpers.storeById(vm.scorecard.questions, questions);
           Helpers.parseQuestions(vm.scorecard.questions);
 
           return ReviewService.getReviewItems($stateParams.reviewId);
 
-        }).then(function(data) {
-          var answers = data.data.result.content;
+        }).then(function(answers) {
 
           Helpers.parseAnswers(vm.scorecard.questions, answers);
 

app/services/review.service.js

@@ -52,11 +52,10 @@
       // var method = isPreviouslySaved ? 'PUT' : 'POST';
       // var url = CONSTANTS.API_URL + '/reviewItems/';
       // return ApiService.requestHandler(method, url, JSON.stringify(body));
-      // body = JSON.stringify(body);
       if (isPreviouslySaved) {
         return api.all('reviewItems').customPUT(body, null, null, null)
       } else {
-        return api.all('reivewItems').post(body)
+        return api.all('reviewItems').post(body)
       }
     }
 
@@ -67,7 +66,7 @@
         id: reviewId
       }
       // return ApiService.requestHandler('PUT', url, JSON.stringify(body));
-      api.one('reviews', reviewId).put()
+      return api.one('reviews', reviewId).customPUT(body, null, null, null)
     }
   };
 })();

app/services/scorecard.service.js

@@ -18,14 +18,23 @@
 
     function getScorecardById(scorecardId) {
         return api.all('scorecards').getList({filter: encodeURIComponent("scorecardId="+scorecardId)})
+          .then(function(data) {
+            return data.plain()
+          })
     }
 
     function getScorecard(challengeId) {
         return api.all('scorecards').getList({filter: encodeURIComponent("challengeId="+challengeId)})
+        .then(function(data) {
+            return data.plain()
+          })
     }
 
     function getScorecardQuestions(scorecardId) {
         return api.all('scorecardQuestions').getList({filter: encodeURIComponent("scorecardId="+scorecardId)})
+        .then(function(data) {
+            return data.plain()
+          })
     }
   };
 })();