Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit c2331d4

Browse files
committed
Final fix - all review comments
1 parent 414474c commit c2331d4

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

app/directives/distribution-graph/distribution-graph.directive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
271271
})
272272

273273
function isInArray(value, array) {
274-
return array.indexOf(value) > -1;
274+
return array.indexOf(value) > -1
275275
}
276276

277277
svg.selectAll('line.xaxis')

app/directives/history-graph/history-graph.directive.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,5 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
319319
})
320320
return colors[0] && colors[0].color || 'black'
321321
}
322-
323-
function isInArray(value, array) {
324-
return array.indexOf(value) > -1;
325-
}
326322
}
327323
})()

app/topcoder.constants.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,5 @@ angular.module('CONSTANTS', []).constant('CONSTANTS', {
4444
'REGISTERED' : 'REGISTERED',
4545
'SUBMISSION_TYPE_CONTEST': 'Contest Submission',
4646
'STATUS_ACTIVE' : 'Active',
47-
'STATUS_COMPLETED_WITHOUT_WIN' : 'Completed Without Win',
48-
'CHALLENGE_DETAIL_URL' : 'https://www.topcoder-dev.com/challenge-details/',
49-
'SRM_DETAIL_URL': 'https://community.topcoder-dev.com/stat?c=round_overview&rd=',
50-
'MARATHON_DETAIL_URL': 'https://community.topcoder-dev.com/longcontest/stats/?module=ViewOverview&rd='
47+
'STATUS_COMPLETED_WITHOUT_WIN' : 'Completed Without Win'
5148
})

package.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
},
1010
"devDependencies": {
1111
"angular-mocks": "^1.4.9",
12-
"appirio-tech-webpack-config": "^0.3.5",
13-
"babel-plugin-add-module-exports": "^0.2.1",
12+
"appirio-tech-webpack-config": "^0.3.0",
1413
"babel-polyfill": "^6.7.2",
1514
"bardjs": "^0.1.8",
1615
"bower": "^1.6.8",
@@ -55,8 +54,7 @@
5554
"angularjs-toaster": "^1.0.0",
5655
"appirio-styles": "0.x.x",
5756
"appirio-tech-ng-iso-constants": "^1.0.6",
58-
"appirio-tech-ng-ui-components": "^2.2.4",
59-
"appirio-tech-react-components": "^0.0.12",
57+
"appirio-tech-ng-ui-components": "^2.1.2",
6058
"auth0-angular": "^4.1.0",
6159
"auth0-js": "^6.8.0",
6260
"d3": "^3.5.14",
@@ -71,7 +69,6 @@
7169
"restangular": "^1.5.2",
7270
"tc-angular-ellipsis": "^0.1.6",
7371
"topcoder-app-r": "^1.0.0",
74-
"webpack-hot-middleware": "^2.10.0",
7572
"xml2js": "^0.4.16",
7673
"zepto": "^1.0.1"
7774
}

0 commit comments

Comments
 (0)