Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit bf2391f

Browse files
author
Parth Shah
committed
Merge branch 'master' of github.com:appirio-tech/topcoder-app
2 parents 6612296 + 5817d97 commit bf2391f

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

app/my-dashboard/srms/srms.controller.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
function getSRMs() {
2323
var params = {
2424
filter: 'status=future',
25-
orderBy: 'registrationStartAt',
2625
limit: 3
2726
};
2827

app/my-srms/my-srms.controller.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@
5252

5353
function changeFilter(filter) {
5454
vm.statusFilter = filter;
55-
// for upcoming SRMs sorting is done ascending order of codingStartAt
56-
// for past SRMs sorting is done descending order of codingEndAt
57-
vm.orderBy = filter === 'future'? 'codingStartAt': 'codingEndAt';
55+
vm.orderBy = filter === 'future'? 'startDate': 'endDate';
5856
vm.reverseOrder = filter !== 'future';
5957
// update url but don't reload
6058
$state.go($state.$current.name, {status: filter}, {notify: false});

app/my-srms/my-srms.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('My SRMs Controller', function() {
7777
// by default it should load upcoming SRMs
7878
expect(mySRMs.statusFilter).to.equal('past');
7979
expect(mySRMs.srms).to.exist;
80-
expect(mySRMs.orderBy).to.equal('codingEndAt');
80+
expect(mySRMs.orderBy).to.equal('endDate');
8181
expect(mySRMs.reverseOrder).to.be.true;
8282
expect(mySRMs.srms.length).to.equal(srms.length - 1);
8383
expect(spy.withArgs(0).calledOnce);
@@ -107,7 +107,7 @@ describe('My SRMs Controller', function() {
107107
it('upcoming SRMs should be fetched', function() {
108108
expect(mySRMs.srms).to.exist;
109109
expect(mySRMs.statusFilter).to.equal('future');
110-
expect(mySRMs.orderBy).to.equal('codingStartAt');
110+
expect(mySRMs.orderBy).to.equal('startDate');
111111
expect(mySRMs.reverseOrder).to.be.false;
112112
expect(mySRMs.srms).to.exist;
113113
// should have one extra srm for past filter as per mocked method

0 commit comments

Comments
 (0)