Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit a8b8d01

Browse files
committed
Merge pull request #438 from appirio-tech/feature/tom-settings-v2
first round of changes
2 parents 772142a + 61293dd commit a8b8d01

File tree

6 files changed

+66
-22
lines changed

6 files changed

+66
-22
lines changed

app/directives/external-account/external-account.directive.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.ext-tile(ng-repeat="account in accountList | orderBy:'order'", ng-click="!account.disabled && !readOnly && handleClick(account.provider, account.status)", ng-class="{'connected': account.status === 'linked', 'connecting': account.status === 'pending', 'disabled': account.disabled, 'enabled': !account.disabled, 'read-only': readOnly}")
1+
.ext-tile(ng-repeat="account in accountList | orderBy:'order'", ng-click="!account.disabled && !readOnly && handleClick(account.provider, account.status)", ng-class="{'connected': account.status === 'linked', 'connecting': account.status === 'pending', 'disabled': account.disabled, 'enabled': !account.disabled, 'read-only': readOnly, 'connect': account.status === 'unlinked' && !account.disabled}")
22
.external-account-box(ng-class="account.colorClass")
33
i.fa(ng-class="account.className")
44

app/settings/account-info/account-info.jade

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66

77
.section-fields
88
.form-label.username Username
9-
input.form-field(name="username", value="{{vm.userData.handle}}", disabled=true)
9+
input.form-field.grey(name="username", value="{{vm.userData.handle}}", disabled=true)
1010

1111
.form-label email
12-
input.form-field(name="email", value="{{vm.userData.email}}", disabled=true)
12+
input.form-field.grey(name="email", value="{{vm.userData.email}}", disabled=true)
1313

1414
div(ng-hide="vm.isSocialRegistration")
1515
form(name="vm.newPasswordForm", role="form", ng-submit="vm.newPasswordForm.$valid && vm.submitNewPassword()", novalidate)
@@ -109,7 +109,7 @@
109109
p(ng-show="vm.accountInfoForm.address.$error.required") Please enter an address
110110

111111
.form-label Address 2
112-
span(style="text-transform: none;")  (opt., suite, etc.)
112+
span(style="text-transform: none;")  (apt., suite, etc.)
113113
input.tc-input(
114114
name="address2",
115115
type="text",
@@ -145,7 +145,7 @@
145145
.account-info-error(ng-show="vm.addressDirty && vm.accountInfoForm.state.$invalid")
146146
p(ng-show="vm.accountInfoForm.state.$error.required") Please enter a state or province
147147

148-
.form-label Zip
148+
.form-label Zip/Post Code
149149
input.tc-input(
150150
name="zipcode", type="text",
151151
placeholder="Zip"
@@ -158,7 +158,9 @@
158158
.account-info-error(ng-show="vm.addressDirty && vm.accountInfoForm.zipcode.$invalid")
159159
p(ng-show="vm.accountInfoForm.zipcode.$error.required") Please enter a zip
160160

161-
.form-label Country
161+
.form-label
162+
span Country
163+
span.mandatory *mandatory
162164
angucomplete-alt(
163165
input-name="country",
164166
input-class="tc-input",
@@ -177,5 +179,5 @@
177179
p(ng-show="vm.accountInfoForm.country.$error.required") Please choose a country from the list.
178180

179181

180-
.button-container
181-
button.tc-btn.tc-btn-l(type="submit", tc-busy-button, tc-busy-when="vm.formProcessing.accountInfoForm", ng-disabled="vm.accountInfoForm.$invalid", ng-class="{'enabled-button': vm.accountInfoForm.$valid}") Save
182+
.save-section
183+
button.save.tc-btn.tc-btn-l(type="submit", tc-busy-button, tc-busy-when="vm.formProcessing.accountInfoForm", ng-disabled="vm.accountInfoForm.$invalid", ng-class="{'enabled-button': vm.accountInfoForm.$valid}") Save

app/settings/edit-profile/edit-profile.jade

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,20 @@
4949
.settings-section.tracks
5050
.section-info
5151
h2 Tracks
52-
.description Topcoder's three categories of challenges... please pick at least one on your skills and interests
52+
.description Topcoder's three categories of challenges... please pick at least one based on your skills and interests.
5353

5454

5555
.section-fields
5656
track-toggle(tracks="vm.tracks")
5757

58-
button.tc-btn.tc-btn-secondary.tc-btn-l(ng-show="!(vm.editProfile.$invalid || vm.editProfile.$pristine)", type="submit", tc-busy-button, tc-busy-when="vm.profileFormProcessing" ng-disabled="vm.editProfile.$invalid || vm.editProfile.$pristine", ng-class="{' ': vm.editProfile.$valid, 'disabled': disabled}") Save
59-
button.tc-btn.tc-btn-secondary.tc-btn-l.disabled(ng-show="vm.editProfile.$invalid || vm.editProfile.$pristine", type="button") Save
58+
.save-section
59+
button.tc-btn.tc-btn-primary.tc-btn-m(ng-show="!(vm.editProfile.$invalid || vm.editProfile.$pristine)", type="submit", tc-busy-button, tc-busy-when="vm.profileFormProcessing" ng-disabled="vm.editProfile.$invalid || vm.editProfile.$pristine", ng-class="{' ': vm.editProfile.$valid, 'disabled': disabled}") Save
60+
button.tc-btn.tc-btn-secondary.tc-btn-m.disabled(ng-show="vm.editProfile.$invalid || vm.editProfile.$pristine", type="button") Save
6061

6162
.settings-section.skills
6263
.section-info
6364
h2 skills
64-
.description Languages, environments, frameworks, libraries, platforms, tools, and any other technologies that you know well
65+
.description Languages, environments, frameworks, libraries, platforms, tools, and any other technologies that you know well.
6566

6667
.section-fields
6768
.field-label Add a new skill

assets/css/directives/external-account.scss

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,12 @@
2929
}
3030
}
3131

32+
&.connect {
33+
.external-account-box {
34+
background-color: #fbfbfb;
35+
}
36+
}
37+
3238
&.connected,
3339
&.enabled:hover {
3440
.el-weblinks i {color: #82A0AA;}
@@ -41,6 +47,13 @@
4147
.el-github i {color: #4B3D74;}
4248
}
4349

50+
&.enabled.connect:hover {
51+
.external-account-box {
52+
background-color: #f2faff;
53+
border: 1px solid #85ccff;
54+
}
55+
}
56+
4457
&.read-only {
4558
cursor: default;
4659
}
@@ -71,7 +84,7 @@
7184
.provider {
7285
margin-top: 8px;
7386
@include sofia-pro-medium;
74-
font-size: 10px;
87+
font-size: 12px;
7588
line-height: 13px;
7689
text-align: center;
7790
text-transform: uppercase;

assets/css/settings/account-info.scss

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,18 @@
1616
.section-fields {
1717
display: flex;
1818
flex-direction: column;
19+
.form-field {
20+
&.grey {
21+
background-color: #fcfcfc;
22+
}
23+
}
1924
.form-label {
2025
margin-top: 30px;
2126
&.username {
2227
margin-top: 0px;
2328
}
2429
}
25-
.button-container {
26-
button.save {
27-
margin-top: 20px;
28-
}
29-
}
30+
3031
}
3132
}
3233

@@ -94,6 +95,23 @@
9495
@include ui-enabled-button;
9596
}
9697
}
98+
.save-section {
99+
width: 95%;
100+
margin-left: auto;
101+
margin-right: auto;
102+
background-color: #fcfcfc;
103+
border-top: 1px solid #f0f0f0;
104+
display: flex;
105+
flex-direction: column;
106+
justify-content: center;
107+
align-items: center;
108+
109+
button.save {
110+
margin-bottom: 15px;
111+
margin-top: 15px;
112+
width: 100px;
113+
}
114+
}
97115
}
98116

99117
@media only screen and (min-width: 760px) {

assets/css/settings/settings.scss

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,11 +260,21 @@
260260
margin-top: 40px;
261261
}
262262

263+
264+
}
265+
.save-section {
266+
width: 95%;
267+
margin-left: auto;
268+
margin-right: auto;
269+
background-color: #fcfcfc;
270+
border-top: 1px solid #f0f0f0;
271+
display: flex;
272+
flex-direction: column;
273+
justify-content: center;
274+
align-items: center;
263275
button {
264-
margin-bottom: 20px;
265-
align-self: flex-start;
266-
margin-left: 25%;
267-
margin-top: 20px;
276+
margin-bottom: 15px;
277+
margin-top: 15px;
268278
width: 100px;
269279
}
270280
}

0 commit comments

Comments
 (0)