Prevent the section from flickering

Author: Nick Litwin

app/settings/account-info/account-info.controller.js

@@ -16,6 +16,7 @@
 
     function activate() {
       vm.isSocialRegistrant = false;
+      vm.loading = true;
 
       vm.formProcessing = {
         accountInfoForm: false,
@@ -28,10 +29,12 @@
       UserService.getUserProfile({fields: 'credential'})
       .then(function(res) {
         vm.isSocialRegistrant = !res.credential.hasPassword;
+        vm.loading = false;
       })
       .catch(function(err) {
         $log.error("Error fetching user profile. Redirecting to edit profile.");
         $state.go('settings.profile');
+        vm.loading = false;
       });
 
       vm.countries = ISO3166.getAllCountryObjects();

app/settings/account-info/account-info.jade

@@ -11,7 +11,7 @@
       .form-label Email
       input.form-field.grey(name="email", value="{{vm.userData.email}}", disabled=true)
 
-      div(ng-hide="vm.isSocialRegistrant")
+      div(ng-if="!vm.isSocialRegistrant && !vm.loading")
         form(name="vm.newPasswordForm", role="form", ng-submit="vm.newPasswordForm.$valid && vm.submitNewPassword()", novalidate)
           .form-label Current password
 
@@ -45,7 +45,7 @@
             button.tc-btn.save(type="submit", tc-busy-button, tc-busy-when="vm.formProcessing.newPasswordForm", ng-disabled="vm.newPasswordForm.$invalid || vm.newPasswordForm.$pristine", ng-class="{'disabled': vm.newPasswordForm.$invalid || vm.newPasswordForm.$pristine}") Change Password
 
 
-      div(ng-show="vm.isSocialRegistrant")
+      div(ng-if="vm.isSocialRegistrant && !vm.loading")
         p You joined Topcoder by using an external account, so we don't have a password for you.
 
   form(name="vm.accountInfoForm", role="form", novalidate, autocomplete="off")