Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 83a3daa

Browse files
committed
Merge pull request #645 from appirio-tech/SUP-2939-page-error
Add outstanding error and css updates
2 parents cecf5f6 + bcb0e79 commit 83a3daa

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

app/submissions/submit-file/submit-file.controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
});
161161
}
162162

163-
console.log('ABOUT TO SEND: ', vm.submissionsBody);
163+
console.log('Body for request: ', vm.submissionsBody);
164164
SubmissionsService.getPresignedURL(vm.submissionsBody, files);
165165
}
166166
}

app/submissions/submit-file/submit-file.jade

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
p Please be sure to double-check that you have submitted the correct files and that your JPG files (if applicable) are in RGB color mode.
2323

24-
a(href="http://help.{{DOMAIN}}/design/submitting-to-a-design-challenge/formatting-your-submission-for-design-challenges/") Learn more about formatting your submission file
24+
a(ng-href="http://help.{{DOMAIN}}/design/submitting-to-a-design-challenge/formatting-your-submission-for-design-challenges/") Learn more about formatting your submission file
2525

2626
.form-block__fields
2727
.fieldset
@@ -103,7 +103,7 @@
103103
.form-block__text
104104
p Check to see if your font is on the Studio Standard Fonts list. If it is, leave the URL field blank.
105105

106-
p Read the #[a(href="Need link") Studio Fonts Policy].
106+
p Read the #[a(ng-href="http://help.{{DOMAIN}}/design/design-copyright-and-font-policies/font-policy-for-design-challenges/") Studio Fonts Policy].
107107

108108
p If your font is not on the list, you must provide the URL to the font page (not file) from one of the approved font websites in the dropdown box.
109109

@@ -116,7 +116,7 @@
116116
.form-block__title Did you use stock art?
117117

118118
.form-block__text
119-
p If you used any stock photos in your design mocks, please provide the location and details so that the client can obtain them. Follow the guidelines at our #[a(href="Need link") Studio Stock Art Policy].
119+
p If you used any stock photos in your design mocks, please provide the location and details so that the client can obtain them. Follow the guidelines at our #[a(ng-href="http://help.{{DOMAIN}}/design/design-copyright-and-font-policies/policy-for-stock-photos-in-design-submissions/") Studio Stock Art Policy].
120120

121121
.form-block__fields
122122
.fieldsets
@@ -149,7 +149,9 @@
149149
button.fieldset__button.tc-btn.tc-btn-s(type="button", ng-click="vm.createAnotherStockArtFieldset()") + Add Stock Photo
150150

151151
.panel-footer
152-
p Submitting your files means you hereby agree to the #[a(href="https://www.{{DOMAIN}}/community/how-it-works/terms/", target="_blank") Topcoder terms of use] and to the extent your uploaded file wins a Topcoder Competition, you hereby assign, grant, and transfer to Topcoder all rights in and title to the Winning Submission (as further described in the terms of use).
152+
p Submitting your files means you hereby agree to the #[a(ng-href="https://www.{{DOMAIN}}/community/how-it-works/terms/", target="_blank") Topcoder terms of use] and to the extent your uploaded file wins a Topcoder Competition, you hereby assign, grant, and transfer to Topcoder all rights in and title to the Winning Submission (as further described in the terms of use).
153+
154+
p.tc-error-messages(ng-show="vm.submissionForm.hasAgreedToTerms && submissionForm.$invalid") There are outstanding problems with this page. Fix them before you can upload your submission.
153155

154156
.checkbox.flex.center
155157
input(type="checkbox", ng-model="vm.submissionForm.hasAgreedToTerms", id="agree-to-terms", required)

assets/css/submissions/submit-file.scss

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
.panel-footer {
1010
text-align: center;
1111

12-
p {
12+
p:first-child {
1313
margin-bottom: 30px;
1414
@include font-with-weight('Merriweather Sans', 300);
1515
font-size: 13px;
@@ -18,6 +18,13 @@
1818
text-align: left;
1919
}
2020

21+
.tc-error-messages {
22+
width: 100%;
23+
max-width: none;
24+
margin-bottom: 30px;
25+
text-align: center;
26+
}
27+
2128
.checkbox {
2229
label {
2330
margin-left: 10px;
@@ -45,7 +52,6 @@ tc-form-fonts {
4552
}
4653

4754
.Select {
48-
max-width: 300px;
4955
margin-bottom: 20px;
5056
}
5157

0 commit comments

Comments
 (0)