Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 7ccf729

Browse files
author
vikasrohit
committed
Merge pull request #352 from appirio-tech/feature/validation-error-styling-login-reg
SUP-1792, [Registration] Apply mobile design
2 parents e53ef98 + 761c20f commit 7ccf729

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

app/account/register/register.jade

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
minlength="1"
3535
)
3636

37-
.form-errors
38-
p.form-error(ng-show="vm.registerForm.country.$error.required") Please choose a country from the list
37+
.form-input-error(ng-show="vm.registerForm.country.$dirty && vm.registerForm.country.$invalid", ng-messages="vm.registerForm.country.$error")
38+
p.form-error(ng-message="required") Please choose a country from the list
3939

4040
.section-break
4141
hr
@@ -53,10 +53,13 @@
5353

5454
p It can contain letters, numbers, and these characters: -_.{}[]
5555

56-
.form-errors
57-
p.form-error(ng-show="vm.registerForm.username.$dirty && vm.registerForm.username.$error.usernameIsFree", ng-bind="vm.usernameErrorMessage")
56+
.form-input-error(ng-if="vm.registerForm.username.$dirty && vm.registerForm.username.$invalid", ng-messages="vm.registerForm.username.$error")
57+
p.form-error(ng-message="required") Please enter a username.
58+
p.form-error(ng-message="usernameIsFree") {{vm.usernameErrorMessage}}
5859

59-
p.form-error(ng-show="vm.registerForm.username.$dirty && (vm.registerForm.username.$error.minlength || vm.registerForm.username.$error.maxlength)") That username is not the correct length or format.
60+
p.form-error(ng-message="minlength") That username is not the correct length or format.
61+
62+
p.form-error(ng-message="maxlength") That username is not the correct length or format.
6063

6164
.validation-bar(ng-class="{ 'error-bar': (vm.registerForm.email.$dirty && vm.registerForm.email.$invalid), 'success-bar': (vm.registerForm.email.$valid) }")
6265
input-sticky-placeholder(sticky-placeholder="Email", ng-model="vm.email")
@@ -69,10 +72,12 @@
6972

7073
p We'll occasionally send you emails related to your activities or interests.
7174

72-
.form-errors
73-
p.form-error(ng-show="vm.registerForm.email.$dirty && (vm.registerForm.email.$error.emailIsAvailable || vm.registerForm.email.$error.validEmail)", ng-bind="vm.emailErrorMessage")
75+
.form-input-error(ng-show="vm.registerForm.email.$dirty && vm.registerForm.email.$invalid", ng-messages="vm.registerForm.email.$error")
76+
p.form-error(ng-message="emailIsAvailable") {{vm.emailErrorMessage}}
77+
78+
p.form-error(ng-message="validEmail") {{vm.emailErrorMessage}}
7479

75-
p.form-error(ng-show="vm.registerForm.email.$dirty && vm.registerForm.email.$error.required") Please enter an email address.
80+
p.form-error(ng-message="required") Please enter an email address.
7681

7782
.validation-bar(ng-class="{ 'success-bar': (vm.registerForm.password.$valid) }")
7883
toggle-password-with-tips(ng-if="!vm.isSocialRegistration")

app/index.jade

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ html
107107
script(src='../bower_components/intro.js/intro.js')
108108
script(src='../bower_components/angular-intro.js/src/angular-intro.js')
109109
script(src='../bower_components/angular-jwt/dist/angular-jwt.js')
110+
script(src='../bower_components/angular-messages/angular-messages.js')
110111
script(src='../bower_components/angular-sanitize/angular-sanitize.js')
111112
script(src='../bower_components/angular-ui-router/release/angular-ui-router.js')
112113
script(src='../bower_components/x2js/xml2json.min.js')

app/topcoder.module.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
'CONSTANTS',
2929
'dcbImgFallback',
3030
'toaster',
31-
'angular-intro'
31+
'angular-intro',
32+
'ngMessages'
3233
];
3334

3435
angular.module('topcoder', dependencies).run(appRun);

bower.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
"angular-img-fallback": "~0.1.3",
3333
"angular-intro.js": "~1.3.0",
3434
"angular-jwt": "~0.0.9",
35+
"angular-messages": "~1.4.7",
3536
"angular-sanitize": "1.4.x",
3637
"angular-ui-router": "~0.2.15",
3738
"angular-xml": "~2.1.1",

0 commit comments

Comments
 (0)