AS#102438220269693, Clean up lint errors for app/scripts/filepicker.js & angular-filepicker.js

-- Fixed lint errors

Author: vikasrohit

.eslintignore

@@ -0,0 +1,3 @@
+.gitignore
+assets/scripts/*.*
+report/**/*.*

app/directives/tc-fp-file-input/tc-fp-file-input.directive.js

@@ -33,36 +33,36 @@ import _ from 'lodash'
         }
         // set extensions
         if (scope.fieldId.indexOf('ZIP') > -1) {
-          scope.extensions = ".zip"
+          scope.extensions = '.zip'
         } else if (scope.fieldId.indexOf('DESIGN_COVER') > -1) {
-          scope.extensions = ".png,.jpeg,.jpg,.bmp"
+          scope.extensions = '.png,.jpeg,.jpg,.bmp'
         }
 
         // set default services
-        scope.fpServices = scope.fpServices || "COMPUTER,GOOGLE_DRIVE,BOX,DROPBOX"
+        scope.fpServices = scope.fpServices || 'COMPUTER,GOOGLE_DRIVE,BOX,DROPBOX'
         scope.fpContainer = CONSTANTS.FILE_PICKER_SUBMISSION_CONTAINER_NAME || 'submission-staging-dev'
 
         // set max size
         scope.maxSize = 500*1024*1024
 
-        var key, value;
+        var key, value
         /*
          *pass original event
         */
         element.bind('change', function(event) {
-            event.preventDefault()
-            scope.onSuccess(event.originalEvent || event);
-            $rootScope.$apply()
-        });
-        element = element.length ? element[0] : element;
+          event.preventDefault()
+          scope.onSuccess(event.originalEvent || event)
+          $rootScope.$apply()
+        })
+        element = element.length ? element[0] : element
         for (key in attrs.$attr){
-            value = attrs.$attr[key]
-            element.setAttribute(value, attrs[key])
+          value = attrs.$attr[key]
+          element.setAttribute(value, attrs[key])
         }
         filepickerService.constructWidget(element)
 
         scope.onSuccess = function (event) {
-          debugger
+          // debugger
           var fpFile = event.fpfile
           var _file = {
             name: scope.filename || fpFile.filename,

app/services/submissions.service.js

@@ -27,9 +27,9 @@ import angular from 'angular'
 
         // uploadSubmissionFileToS3(response, response.data.files, files, progressCallback)
 
-        console.log(response);
+        logger.debug(response)
 
-        processSubmission(response, progressCallback);
+        processSubmission(response, progressCallback)
       })
       .catch(function(err) {
         logger.error('Could not get presigned url', err)
@@ -136,7 +136,7 @@ import angular from 'angular'
 
         progressCallback.call(progressCallback, 'FINISH', 100)
 
-        return response;
+        return response
       })
       .catch(function(err) {
         logger.error('Could not start processing', err)

app/submissions/submit-design-files/submit-design-files.controller.js

@@ -12,7 +12,6 @@ import _ from 'lodash'
     if (!challengeToSubmitTo.challenge) { return }
 
     var vm = this
-    var files = {}
     var fileUploadProgress = {}
     vm.urlRegEx = new RegExp(/^(http(s?):\/\/)?(www\.)?[a-zA-Z0-9\.\-\_]+(\.[a-zA-Z]{2,3})+(\/[a-zA-Z0-9\_\-\s\.\/\?\%\#\&\=]*)?$/)
     vm.rankRegEx = new RegExp(/^[1-9]\d*$/)
@@ -149,15 +148,15 @@ import _ from 'lodash'
       vm.submissionsBody.data.fonts = processedFonts
       SubmissionsService.startSubmission(vm.submissionsBody, updateProgress)
       .then(function(newSubmission) {
-        logger.debug("New Submission: ", newSubmission)
+        logger.debug('New Submission: ', newSubmission)
         //SubmissionsService.processSubmission(newSubmission, updateProgress)
       })
       .then(function(processedSubmission) {
-        logger.debug("Processed Submission: ", processedSubmission)
+        logger.debug('Processed Submission: ', processedSubmission)
 
       })
       .catch(function(err) {
-        logger.error("Submission processing failed ", err)
+        logger.error('Submission processing failed ', err)
       })
     }
 

package.json

@@ -4,7 +4,7 @@
   "scripts": {
     "build": "webpack --bail --progress --build --tc",
     "start": "webpack-dev-server --history-api-fallback --host 0.0.0.0 --dev --tc --inline --progress --port 3000",
-    "lint": "eslint --ignore-path .gitignore .",
+    "lint": "eslint .",
     "test": "karma start --tc --test"
   },
   "devDependencies": {

webpack.config.js

@@ -19,8 +19,8 @@ const config = require('appirio-tech-webpack-config')({
   },
   plugins: [
     new BowerWebpackPlugin({
-      moduleDirectories: ["bower_components"],
-      manifestFiles: "bower.json",
+      moduleDirectories: ['bower_components'],
+      manifestFiles: 'bower.json',
       includes: /.*/,
       excludes: [],
       searchResolveModulesDirectories: true