Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 6d9cd5c

Browse files
author
vikasrohit
committed
Merge branch 'hotfix/mailchimp-constants-webpack-fix' into dev
2 parents 0a13acc + 58b6757 commit 6d9cd5c

File tree

5 files changed

+24
-5
lines changed

5 files changed

+24
-5
lines changed

app/blocks/logger/logger.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import angular from 'angular'
3333
$log.error(message)
3434

3535
if (window.NREUM) {
36-
window.NREUM.noticeError(message)
36+
window.NREUM.noticeError(new Error(message))
37+
}
38+
// logging to Sentry
39+
if (window.Raven) {
40+
window.Raven.captureMessage(message)
3741
}
3842
}
3943

app/index.jade

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ html
1919

2020
include ../assets/scripts/google.analytics.jade
2121
include ../assets/scripts/zendesk-widget.jade
22+
include ../assets/scripts/raven-js.jade
2223

2324
if htmlWebpackPlugin.options.NEW_RELIC_APPLICATION_ID
2425
include ../assets/scripts/newrelic.analytics.jade

app/submissions/submissions.controller.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,22 @@ import angular from 'angular'
55

66
angular.module('tc.submissions').controller('SubmissionsController', SubmissionsController)
77

8-
SubmissionsController.$inject = ['challengeToSubmitTo', '$state']
8+
SubmissionsController.$inject = ['challengeToSubmitTo', '$state', 'logger']
99

10-
function SubmissionsController(challengeToSubmitTo, $state) {
10+
function SubmissionsController(challengeToSubmitTo, $state, logger) {
1111
var vm = this
1212

1313
vm.error = !!challengeToSubmitTo.error
14-
14+
// test to see if sentry logging works
15+
try {
16+
var a = null
17+
a[1].undef
18+
} catch (e) {
19+
if (window.Raven) {
20+
window.Raven.captureException(e)
21+
logger.debug(window.Raven.lastEventId())
22+
}
23+
}
1524
if (vm.error) {
1625
vm.errorType = challengeToSubmitTo.error.type
1726
vm.errorMessage = challengeToSubmitTo.error.message

assets/scripts/raven-js.jade

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
script(type="text/javascript", src="////cdn.ravenjs.com/3.0.4/raven.min.js").
2+
script(type="text/javascript").
3+
Raven
4+
.config('https://[email protected]/79867')
5+
.install()

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"devDependencies": {
1111
"angular-mocks": "^1.4.9",
12-
"appirio-tech-webpack-config": "^0.3.0",
12+
"appirio-tech-webpack-config": "0.3.6",
1313
"babel-polyfill": "^6.7.2",
1414
"bardjs": "^0.1.8",
1515
"bower": "^1.6.8",

0 commit comments

Comments
 (0)