Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 5790094

Browse files
author
vikasrohit
committed
SUP-2410, Fix ordering of sub-tracks on profile and dashboard
-- Ordered the subtract stats by descending order of mostRecentSubmission date for the track/subtrack -- Copilot stats would always be the first one, if available.
1 parent 8c90d8d commit 5790094

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

app/my-dashboard/subtrack-stats/subtrack-stats.controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// filtering is a separate step to allow multiple pre-processings and filter out in single call
2525
subtrackRanks = UserStatsService.filterStats(subtrackRanks);
2626
// sort subtrack ranks
27-
subtrackRanks = $filter('orderBy')(subtrackRanks, 'mostRecentEventDate', true);
27+
subtrackRanks = $filter('orderBy')(subtrackRanks, 'mostRecentSubmissionDate', true);
2828

2929
vm.subtrackRanks = subtrackRanks;
3030
vm.hasRanks = !!vm.subtrackRanks.length;

app/services/profile.service.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@
108108
'rating': subTrack.rank.rating || 0,
109109
'wins': subTrack.wins,
110110
'submissions': (subTrack.submissions && subTrack.submissions.submissions) || 0,
111-
'mostRecentEventDate': new Date(subTrack.mostRecentEventDate)
111+
'mostRecentEventDate': new Date(subTrack.mostRecentEventDate),
112+
'mostRecentSubmissionDate': new Date(subTrack.mostRecentSubmission)
112113
};
113114
}).filter(function(subTrack) {
114115
return !(subTrack.subTrack == 'COPILOT_POSTING' && subTrack.track == 'DEVELOP');
@@ -124,7 +125,8 @@
124125
'challenges': subTrack.challenges,
125126
'wins': subTrack.wins,
126127
'submissions': (subTrack.submissions) || 0,
127-
'mostRecentEventDate': new Date(subTrack.mostRecentEventDate)
128+
'mostRecentEventDate': new Date(subTrack.mostRecentEventDate),
129+
'mostRecentSubmissionDate': new Date(subTrack.mostRecentSubmission)
128130
};
129131
});
130132
}
@@ -135,7 +137,8 @@
135137
'subTrack': 'SRM',
136138
'rank': srmStats.rank.rank,
137139
'rating': srmStats.rank.rating,
138-
'mostRecentEventDate': new Date(srmStats.rank.mostRecentEventDate)
140+
'mostRecentEventDate': new Date(srmStats.rank.mostRecentEventDate),
141+
'mostRecentSubmissionDate': new Date(srmStats.mostRecentSubmission)
139142
});
140143
}
141144
if (stats.DATA_SCIENCE && stats.DATA_SCIENCE.MARATHON_MATCH && stats.DATA_SCIENCE.MARATHON_MATCH.rank) {
@@ -145,7 +148,8 @@
145148
'subTrack': 'MARATHON_MATCH',
146149
'rank': marathonStats.rank.rank,
147150
'rating': marathonStats.rank.rating,
148-
'mostRecentEventDate': new Date(marathonStats.rank.mostRecentEventDate)
151+
'mostRecentEventDate': new Date(marathonStats.rank.mostRecentEventDate),
152+
'mostRecentSubmissionDate': new Date(marathonStats.mostRecentSubmission)
149153
});
150154
}
151155
if (stats.COPILOT) {

0 commit comments

Comments
 (0)