Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 54c2b5d

Browse files
author
Nick Litwin
committed
Merge branch 'dev' into desktop-skill-picker
2 parents 1a2babd + 7f6d89a commit 54c2b5d

File tree

5 files changed

+17
-13
lines changed

5 files changed

+17
-13
lines changed

app/index.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,13 @@ html
9898
script(src='../bower_components/x2js/xml2json.min.js')
9999
script(src='../bower_components/angular-xml/angular-xml.js')
100100
script(src='../bower_components/appirio-tech-ng-iso-constants/dist/ng-iso-constants.js')
101+
script(src='../bower_components/d3/d3.js')
101102
script(src='../bower_components/jstzdetect/jstz.min.js')
102103
script(src='../bower_components/moment/moment.js')
103104
script(src='../bower_components/ng-notifications-bar/dist/ngNotificationsBar.min.js')
104105
script(src='../bower_components/ngDialog/js/ngDialog.js')
105106
script(src='../bower_components/lodash/lodash.js')
106107
script(src='../bower_components/restangular/dist/restangular.js')
107-
script(src='../bower_components/d3/d3.js')
108108
//- endbower
109109
//- inject:nonBowerScripts
110110
script(src="/scripts/auth0.js")

app/services/api.service.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
route: 'members'
7878
})
7979
.addRequestInterceptor(function(element, operation, what, url) {
80-
if (what === 'members') {
80+
if (url.indexOf('members') > -1) {
8181
return {
8282
param: element
8383
};

app/services/image.service.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
return service;
1717

1818
function createFileRecord(S3Response) {
19-
return api.one('members', S3Response.userHandle).one('photo').customPUT(JSON.stringify(S3Response.body))
19+
return api.one('members', S3Response.userHandle).customPUT(S3Response.body, 'photo')
2020
.then(function() {
2121
// Show notification that upload was successful
2222
$rootScope.$broadcast(CONSTANTS.EVENT_PROFILE_UPDATED);
@@ -32,7 +32,7 @@
3232
function getPresignedUrl(userHandle, file) {
3333
var deferred = $q.defer();
3434

35-
api.one('members', userHandle).customPOST(undefined, 'photoUploadUrl', {}, {'Content-Type': file.type})
35+
api.one('members', userHandle).post('photoUploadUrl', {contentType: file.type})
3636
.then(function(response) {
3737
deferred.resolve({
3838
preSignedURL: response.preSignedURL,
@@ -52,21 +52,25 @@
5252
function uploadFileToS3(response) {
5353
var deferred = $q.defer();
5454
var xhr = new XMLHttpRequest();
55-
var formData = new FormData();
56-
formData.append('userimage', response.file, response.file.name);
5755

5856
xhr.open('PUT', response.preSignedURL, true);
59-
xhr.setRequestHeader('Content-Type', 'multipart/form-data');
57+
xhr.setRequestHeader('Content-Type', response.file.type);
6058

6159
// xhr version of the success callback
6260
xhr.onreadystatechange = function() {
6361
var status = xhr.status;
6462
if (((status >= 200 && status < 300) || status === 304) && xhr.readyState === 4) {
65-
$log.info('Successfully uploaded file')
63+
$log.info('Successfully uploaded file');
6664
deferred.resolve({
6765
userHandle: response.userHandle,
68-
body: { param: { token: response.token } }
66+
body: {
67+
token: response.token,
68+
contentType: response.file.type
69+
}
6970
});
71+
} else if (status >= 400) {
72+
$log.error('Error uploading to S3 with status: ' + status);
73+
deferred.reject(err);
7074
}
7175
};
7276

@@ -75,7 +79,7 @@
7579
deferred.reject(err);
7680
}
7781

78-
xhr.send(formData);
82+
xhr.send(response.file);
7983

8084
return deferred.promise;
8185
}

app/settings/edit-profile/edit-profile.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
.fields
99
.field-section.edit-image
10-
img.profile-circle(fallback-src="/images/avatarPlaceholder.png", loading-src="/images/avatarPlaceholder.png", ng-src="{{vm.userData.photo.photoUrl}}")
10+
img.profile-circle(fallback-src="/images/avatarPlaceholder.png", ng-src="{{vm.userData.photoURL}}")
1111

1212
.upload-image
1313
p Edit Image

bower.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@
3535
"angular-ui-router": "~0.2.15",
3636
"angular-xml": "~2.1.1",
3737
"appirio-tech-ng-iso-constants": "[email protected]:appirio-tech/ng-iso-constants#~1.0.1",
38+
"d3": "~3.5.6",
3839
"devicon": "*",
3940
"fontawesome": "~4.3.0",
4041
"jstzdetect": "~1.0.6",
4142
"moment": "~2.10.3",
4243
"ng-notifications-bar": "~0.0.15",
4344
"ngDialog": "0.5.1",
44-
"restangular": "~1.5.1",
45-
"d3": "~3.5.6"
45+
"restangular": "~1.5.1"
4646
},
4747
"devDependencies": {
4848
"bardjs": "~0.1.4",

0 commit comments

Comments
 (0)