fix icon urls to be single strings

Author: thabofletcher

app/directives/header/header-menu-item.directive.jade

@@ -1,17 +1,17 @@
 // clean srefs
 li.submenu-item(ng-if="item.sref && !item.srefParams")
   a.menu-link(ui-sref="{{item.sref}}" ng-class="{ 'active': isActive() }" )
-    img.menu-icon(ng-src="/images/nav/{{item.icon}}.svg")
+    img.menu-icon(ng-src="{{item.icon}}")
     .menu-text {{item.text}}
 
 // external links
 li.submenu-item(ng-if="item.href && !item.srefParams")
   a.menu-link(ng-click="$event.stopPropagation();" ng-href="{{item.href}}" ng-class="{ 'active': isActive() }" target="_blank")
-    img.menu-icon(ng-src="/images/nav/{{item.icon}}.svg")
+    img.menu-icon(ng-src="{{item.icon}}")
     .menu-text {{item.text}}
 
 // srefs with params 
 li.submenu-item(ng-if="item.srefParams")
   a.menu-link(ng-href="{{wtfhref}}" ng-class="{ 'active': isActive() }" )
-    img.menu-icon(ng-src="/images/nav/{{item.icon}}.svg")
+    img.menu-icon(ng-src="{{item.icon}}")
     .menu-text {{item.text}}

app/index.jade

@@ -98,7 +98,7 @@ html
     script(src='../bower_components/angucomplete-alt/angucomplete-alt.js')
     script(src='../bower_components/angular-cookies/angular-cookies.js')
     script(src='../bower_components/angular-dropdowns/dist/angular-dropdowns.js')
-    script(src='../bower_components/angular-filter/dist/angular-filter.min.js')
+    script(src='../bower_components/angular-filter/dist/angular-filter.js')
     script(src='../bower_components/angular-img-fallback/angular.dcb-img-fallback.js')
     script(src='../bower_components/intro.js/intro.js')
     script(src='../bower_components/angular-intro.js/src/angular-intro.js')

app/layout/header/header.controller.js

@@ -18,24 +18,24 @@
     vm.menuLinks = 
     {
       'compete': [        
-          { 'href':  "/challenges/design/active/", 'text': 'DESIGN CHALLENGES', 'icon': 'design' },
-          { 'href':  "/challenges/develop/active", 'text': 'DEVELOPMENT CHALLENGES', 'icon': 'development' },
-          { 'href':  "/challenges/data/active", 'text': 'DATA SCIENCE CHALLENGES', 'icon': 'data-science' },
-          { 'href':  vm.constants.ARENA_URL, 'text': 'THE ARENA', 'icon': 'srms' },
+          { 'href':  "/challenges/design/active/", 'text': 'DESIGN CHALLENGES', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/design.svg' },
+          { 'href':  "/challenges/develop/active", 'text': 'DEVELOPMENT CHALLENGES', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/development.svg' },
+          { 'href':  "/challenges/data/active", 'text': 'DATA SCIENCE CHALLENGES', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/data-science.svg' },
+          { 'href':  vm.constants.ARENA_URL, 'text': 'THE ARENA', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/srms.svg' },
       ],
       'learn': [
-          { 'href': '/community/design/', 'text': 'DESIGN', 'icon': 'scroll-design' },
-          { 'href': '/community/development/', 'text': 'DEVELOPMENT', 'icon': 'scroll-develop' },
-          { 'href': '/community/data-science/', 'text': 'DATA SCIENCE', 'icon': 'scroll-data' },
-          { 'href': '/community/data-science/', 'text': 'COMPETITIVE PROGRAMMING', 'icon': 'srms' },
+          { 'href': '/community/design/', 'text': 'DESIGN', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/scroll-design.svg' },
+          { 'href': '/community/development/', 'text': 'DEVELOPMENT', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/scroll-develop.svg' },
+          { 'href': '/community/data-science/', 'text': 'DATA SCIENCE', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/scroll-data.svg' },
+          { 'href': '/community/data-science/', 'text': 'COMPETITIVE PROGRAMMING', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/srms.svg' },
       ],
       'community': [
-          { 'href': '/community/members/', 'text': 'MEMBERS', 'icon': 'users' },
-          { 'href': '/community/member-programs/', 'text': 'PROGRAMS', 'icon': 'medal' },
-          { 'href': vm.constants.FORUMS_APP_URL, 'text': 'FORUMS', 'icon': 'forum' },
-          { 'href': '/community/statistics/', 'text': 'STATISTICS', 'icon': 'statistics' },
-          { 'href': '/community/events/', 'text': 'EVENTS', 'icon': 'calendar' },
-          { 'href': '/blog/', 'text': 'BLOG', 'icon': 'blog' }
+          { 'href': '/community/members/', 'text': 'MEMBERS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/users.svg' },
+          { 'href': '/community/member-programs/', 'text': 'PROGRAMS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/medal.svg' },
+          { 'href': vm.constants.FORUMS_APP_URL, 'text': 'FORUMS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/forum.svg' },
+          { 'href': '/community/statistics/', 'text': 'STATISTICS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/statistics.svg' },
+          { 'href': '/community/events/', 'text': 'EVENTS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/calendar.svg' },
+          { 'href': '/blog/', 'text': 'BLOG', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/blog.svg' }
       ]
     };
 
@@ -66,10 +66,10 @@
       if (vm.isAuth) {
         vm.userHandle = UserService.getUserIdentity().handle;
         vm.userMenu = [
-          { 'sref': 'dashboard', 'text': 'DASHBOARD', 'icon': 'dashboard' },
-          { 'sref': 'profile.about', 'srefParams': { 'userHandle': vm.userHandle }, 'text': 'MY PROFILE', 'icon': 'badge' },
-          { 'href':  vm.constants.COMMUNITY_URL + '/PactsMemberServlet?module=PaymentHistory&full_list=false', 'text': 'PAYMENTS', 'icon': 'money-bag' },
-          { 'sref': 'settings.profile', 'text': 'SETTINGS', 'icon': 'gear' },
+          { 'sref': 'dashboard', 'text': 'DASHBOARD', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/dashboard.svg' },
+          { 'sref': 'profile.about', 'srefParams': { 'userHandle': vm.userHandle }, 'text': 'MY PROFILE', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/badge.svg' },
+          { 'href':  vm.constants.COMMUNITY_URL + '/PactsMemberServlet?module=PaymentHistory&full_list=false', 'text': 'PAYMENTS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/money-bag.svg' },
+          { 'sref': 'settings.profile', 'text': 'SETTINGS', 'icon': vm.constants.ASSET_PREFIX + '/images/nav/gear.svg' },
         ];
 
         ProfileService.getUserProfile(vm.userHandle)