Rest of cleanup for login

Author: tladendo

app/account/login/login.controller.js

@@ -3,18 +3,19 @@
 
   angular.module('tc.account').controller('LoginController', LoginController);
 
-  LoginController.$inject = ['$log', '$state', '$stateParams', '$location', '$scope', 'TcAuthService', 'AuthTokenService', 'UserService', 'NotificationService', 'Helpers', 'CONSTANTS'];
+  LoginController.$inject = ['$log', '$state', '$stateParams', '$location', '$scope', 'TcAuthService', 'UserService', 'NotificationService', 'Helpers', 'CONSTANTS'];
 
-  function LoginController($log, $state, $stateParams, $location, $scope, TcAuthService, AuthTokenService, UserService, NotificationService, Helpers, CONSTANTS) {
+  function LoginController($log, $state, $stateParams, $location, $scope, TcAuthService, UserService, NotificationService, Helpers, CONSTANTS) {
     var vm = this;
     $log = $log.getInstance("LoginController");
     vm.$stateParams = $stateParams;
     vm.passwordReset = false;
-    vm.usernameExists = true;
     vm.currentPasswordDefaultPlaceholder = "Password";
+    vm.loginErrors = {};
+
     vm.login = login;
     vm.socialLogin = socialLogin;
-    vm.loginErrors = {};
+
     // reference for main vm
     var mainVm = $scope.$parent.main;
 
@@ -26,45 +27,25 @@
       }
     }
 
-    function _doLogin(usernameOrEmail, password) {
-      return TcAuthService.login(usernameOrEmail, password).then(function(data) {
-        // success
-        $log.debug('logged in');
-
-        // setup login event for analytics tracking
-        Helpers.setupLoginEventMetrices(usernameOrEmail);
-        return Helpers.redirectPostLogin($stateParams.next);
-
-      }).catch(function(resp) {
-        $log.warn(resp);
-        switch (resp.status) {
-          case "ACCOUNT_INACTIVE":
-            $state.go('registeredSuccessfully');
-            // user should already be redirected
-            break;
-          case "UNKNOWN_ERROR":
-          default:
-            vm.loginErrors['wrong-password'] = true;
-            vm.password = '';
-        }
-      });
-    }
-
     function login() {
       vm.loginErrors['username-nonexistant'] = false;
       vm.loginErrors['wrong-password'] = false;
+
       // TODO ideally it should be done by dedicated directive to handle all outside clicks
       mainVm.menuVisible = false;
 
       if (Helpers.isEmail(vm.username)) {
+        // the user is loggin in using email
         vm.emailOrUsername = 'email';
+
         // ensure email exists
+        // uses same validity check as registration
+        // valid => email isn't already used by someone
         UserService.validateUserEmail(vm.username).then(function(data) {
           if (data.valid) {
             // email doesn't exist
             vm.loginErrors['username-nonexistant'] = true;
           } else {
-            vm.loginErrors['username-nonexistant'] = false;
             _doLogin(vm.username, vm.currentPassword);
           }
         }).catch(function(resp) {
@@ -74,32 +55,60 @@
           _doLogin(vm.username, vm.currentPassword);
         });
       } else {
+        // the user is logging in using a username
         vm.emailOrUsername = 'username';
+
         // username - make sure it exists
         UserService.validateUserHandle(vm.username).then(function(data) {
           if (data.valid) {
             // username doesn't exist
             vm.loginErrors['username-nonexistant'] = true;
           } else {
-            vm.loginErrors['username-nonexistant'] = false;
             _doLogin(vm.username, vm.currentPassword);
           }
         }).catch(function(resp) {
           // TODO handle error
           // assume email exists, login would in any case if it didn't
-          vm.loginErrors['username-nonexistant'] = false;
           _doLogin(vm.username, vm.currentPassword);
         });
       }
     };
 
-    function socialLogin(backend) {
-      var params = {}, callbackUrl;
+    function _doLogin(usernameOrEmail, password) {
+      return TcAuthService.login(usernameOrEmail, password).then(function(data) {
+        // success
+        $log.debug('logged in');
+
+        // setup login event for analytics tracking
+        Helpers.setupLoginEventMetrics(usernameOrEmail);
+        return Helpers.redirectPostLogin($stateParams.next);
+
+      }).catch(function(resp) {
+        $log.warn(resp);
+        switch (resp.status) {
+          case "ACCOUNT_INACTIVE":
+            $state.go('registeredSuccessfully');
+            // user should already be redirected
+            break;
+          case "UNKNOWN_ERROR":
+          default:
+            vm.loginErrors['wrong-password'] = true;
+            vm.password = '';
+        }
+      });
+    }
+
+    function socialLogin(platform) {
+      // we need to pass on the 'next' param if we have one
+      var params = {};
       if ($stateParams.next) {
         params = {next: $stateParams.next};
       }
-      callbackUrl = $state.href('login', params, {absolute: true});
-      TcAuthService.socialLogin(backend, callbackUrl)
+
+      // redirect back to login
+      var callbackUrl = $state.href('login', params, {absolute: true});
+
+      TcAuthService.socialLogin(platform, callbackUrl)
       .then(function() {
         $log.debug('logged in');
         return Helpers.redirectPostLogin($stateParams.next);

app/services/helpers.service.js

@@ -20,7 +20,7 @@
       getCountyObjFromIP: getCountyObjFromIP,
       redirectPostLogin: redirectPostLogin,
       getSocialUserData: getSocialUserData,
-      setupLoginEventMetrices: setupLoginEventMetrices,
+      setupLoginEventMetrics: setupLoginEventMetrics,
       npad: npad
 
     };
@@ -297,7 +297,7 @@
       }
     }
 
-    function setupLoginEventMetrices (usernameOrEmail) {
+    function setupLoginEventMetrics (usernameOrEmail) {
       if (_kmq) {
         _kmq.push(['identify', usernameOrEmail ]);
       }