Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 46ce862

Browse files
authored
Merge pull request #1094 from Savvas-cl/dev
Fix for issue #1083 Complete Appeals shown only when Submitter role p…
2 parents 07430e1 + 257bd5f commit 46ce862

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

app/directives/challenge-tile/challenge-tile.jade

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020
.stalled-challenge(ng-hide="challenge.userCurrentPhaseEndTime") This challenge is currently paused.
2121

2222
.phase-action(ng-show="challenge.userAction", ng-switch="challenge.userAction")
23-
a.tc-btn.tc-btn-s.tc-btn-wide.tc-btn-ghost.submit(ng-switch-when="Submit", ng-href="{{challenge|challengeLinks:'submit'}}") Submit
23+
a.tc-btn.tc-btn-s.tc-btn-wide.tc-btn-ghost.submit(ng-switch-when="Submit", ng-href="{{challenge|challengeLinks:'submit'}}") Submit
2424
a.tc-btn.tc-btn-s.tc-btn-wide.btn-danger.submit(ng-switch-when="Submit", ng-href="{{challenge|challengeLinks:'unRegister'}}") Unregister
2525
a.tc-btn.tc-btn-s.tc-btn-wide.tc-btn-ghost.submit(ng-switch-when="Appeal", ng-href="{{challenge|challengeLinks:'viewScorecards'}}") View Scorecards
26-
a.tc-btn.tc-btn-s.tc-btn-wide.btn-danger.submit(ng-switch-when="Appeal", ng-href="{{challenge|challengeLinks:'completeAppeals'}}") Complete Appeals
26+
a.tc-btn.tc-btn-s.tc-btn-wide.btn-danger.submit(ng-if="challenge.isSubmitter")(ng-switch-when="Appeal", ng-href="{{challenge|challengeLinks:'completeAppeals'}}") Complete Appeals
2727

2828
.submitted(ng-switch-when="Submitted") Submitted
2929

app/services/challenge.service.js

+4
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ import moment from 'moment'
6767
challenge.userCurrentPhase = 'Stalled'
6868
challenge.userCurrentPhaseEndTime = null
6969
challenge.userAction = null
70+
challenge.isSubmitter = false
7071

7172
if (phases && phases.length) {
7273
hasCurrentPhase = true
@@ -96,6 +97,9 @@ import moment from 'moment'
9697
if (roles && roles.length > 0) {
9798
var submitterRole = _.findIndex(roles, function(role) {
9899
var lRole = role.toLowerCase()
100+
if (lRole === 'submitter') {
101+
challenge.isSubmitter = true
102+
}
99103
return lRole === 'submitter'
100104
})
101105
if (submitterRole === -1) {

0 commit comments

Comments
 (0)