Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 3c1ff04

Browse files
author
vikasrohit
committed
SUP-2839, Profile: # of wins in summary does not match winning challenges shown on Profile
-- Implemented code review suggestions.
1 parent 9e828be commit 3c1ff04

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

app/directives/challenge-tile/challenge-tile.jade

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@
5757
.challenge-details(ng-switch-when="DEVELOP")
5858
dev-challenge-user-place(challenge="challenge", view="view", ng-hide="challenge.isPrivate")
5959
.invite-only-banner(ng-show="challenge.isPrivate")
60-
img(src=require("../../../assets/images/ico-invite-only-prj.svg"))
60+
img(ng-src=require("../../../assets/images/ico-invite-only-prj.svg"))
6161
span INVITE-ONLY CHALLENGE
6262

6363
.challenge-details(ng-switch-when="DESIGN")
6464
design-challenge-user-place(challenge="challenge", view="view", ng-hide="challenge.isPrivate")
6565
.invite-only-banner(ng-show="challenge.isPrivate")
66-
img(src=require("../../../assets/images/ico-invite-only-prj.svg"))
66+
img(ng-src=require("../../../assets/images/ico-invite-only-prj.svg"))
6767
span INVITE-ONLY CHALLENGE
6868

6969
// Only show if not data science track

app/directives/challenge-user-place/design-challenge-user-place.jade

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66

77
.thumbnail(ng-click="!challenge.isPrivate && imageURL && openLightbox()", ng-class="{hidden: challenge.userStatus !== 'PASSED_REVIEW'}")
88
img(ng-show="challenge.submissionViewable && imageURL", ng-src="{{imageURL}}")
9-
img(ng-show="challenge.submissionViewable && !imageURL", ng-src="../../../assets/images/card-bg-no-image.svg")
9+
img(ng-show="challenge.submissionViewable && !imageURL", ng-src=require("../../../assets/images/card-bg-no-image.svg"))
1010
.private-challenge-banner(ng-show="!challenge.submissionViewable")
11-
img(src=require("../../../assets/images/ico-private-prj.svg"))
11+
img(ng-src=require("../../../assets/images/ico-private-prj.svg"))
1212
span PRIVATE CHALLENGE
1313

1414
.thumbnail-gallery(ng-show="numImages", ng-click="!challenge.isPrivate && imageURL && openLightbox()")
@@ -31,9 +31,9 @@
3131

3232
.thumbnail(ng-click="!challenge.isPrivate && imageURL && openLightbox()", ng-class="{hidden: challenge.userStatus !== 'PASSED_REVIEW'}")
3333
img(ng-show="challenge.submissionViewable && imageURL", ng-src="{{imageURL}}")
34-
img(ng-show="challenge.submissionViewable && !imageURL", ng-src="../../../assets/images/card-bg-no-image.svg")
34+
img(ng-show="challenge.submissionViewable && !imageURL", ng-src=require("../../../assets/images/card-bg-no-image.svg"))
3535
.private-challenge-banner(ng-show="!challenge.submissionViewable")
36-
img(src=require("../../../assets/images/ico-private-prj.svg"))
36+
img(ng-src=require("../../../assets/images/ico-private-prj.svg"))
3737

3838
.thumbnail-gallery(ng-show="numImages", ng-click="!challenge.isPrivate && imageURL && openLightbox()")
3939
.gallery-icon

0 commit comments

Comments
 (0)