Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 39672b5

Browse files
committed
Merge pull request #654 from appirio-tech/SUP-2948-char-limits
Add char limits to font and stockart inputs
2 parents 20aeee0 + 871873f commit 39672b5

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

app/directives/tc-form-fonts/tc-form-fonts.jade

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
input-value="font.name",
2020
input-name="fontName{{fontId}}",
2121
input-required="formFonts[fontId].isFontNameRequired",
22-
input-disabled="formFonts[fontId].isFontNameDisabled"
22+
input-disabled="formFonts[fontId].isFontNameDisabled",
23+
maxlength="50"
2324
)
2425

2526
.tc-error-messages(
@@ -36,7 +37,8 @@
3637
input-name="fontUrl{{fontId}}",
3738
input-required="formFonts[fontId].isFontUrlRequired",
3839
input-disabled="formFonts[fontId].isFontUrlDisabled",
39-
input-pattern="urlRegEx"
40+
input-pattern="urlRegEx",
41+
maxlength="100"
4042
)
4143

4244
.tc-error-messages(

app/directives/tc-form-stockart/tc-form-stockart.jade

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,17 @@
55
label-text="Photo Description",
66
placeholder="A picture of a girl",
77
input-value="stockart.description",
8-
input-name="photoDescription{{stockartId}}"
8+
input-name="photoDescription{{stockartId}}",
9+
maxlength="100"
910
)
1011

1112
tc-input.fieldset__input(
1213
label-text="Photo URL",
1314
placeholder="www.istockphoto.com",
1415
input-value="stockart.sourceUrl",
1516
input-name="photoURL{{stockartId}}",
16-
input-pattern="urlRegEx"
17+
input-pattern="urlRegEx",
18+
maxlength="100"
1719
)
1820

1921
.tc-error-messages(ng-show="submissionForm['photoURL' + stockartId].$dirty && submissionForm['photoURL' + stockartId].$invalid")
@@ -23,7 +25,8 @@
2325
label-text="File Number",
2426
placeholder="u2434312",
2527
input-value="stockart.fileNumber",
26-
input-name="fileNumber{{stockartId}}"
28+
input-name="fileNumber{{stockartId}}",
29+
maxlength="50"
2730
)
2831

2932
button.fieldset__button.tc-btn.tc-btn-s(type="button", ng-click="createAdditionalStockartFieldset()", ng-disabled="isButtonDisabled()") + Add Stock Photo

app/directives/tc-input/tc-input.directive.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
inputPattern: '=',
1717
inputRequired: '=',
1818
inputDisabled: '=',
19+
maxlength: '@',
1920
updateValueOnBlur: '&?'
2021
},
2122
link: function(scope, element, attrs) {

app/directives/tc-input/tc-input.jade

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@ input(
77
ng-model="inputValue",
88
ng-pattern="inputPattern",
99
ng-required="inputRequired",
10-
ng-disabled="inputDisabled"
10+
ng-disabled="inputDisabled",
11+
maxlength="{{maxlength}}"
1112
)

0 commit comments

Comments
 (0)