Update copilot challenges on header dash

Author: Nick Litwin

app/my-dashboard/header-dashboard/header-dashboard.controller.js

@@ -6,13 +6,13 @@
   HeaderDashboardController.$inject = [
     '$stateParams',
     'NotificationService',
-    'UserService',
     'ProfileService',
     'CONSTANTS',
-    'userIdentity'
+    'userIdentity',
+    '$q'
   ];
 
-  function HeaderDashboardController($stateParams, NotificationService, UserService, ProfileService, CONSTANTS, userIdentity) {
+  function HeaderDashboardController($stateParams, NotificationService, ProfileService, CONSTANTS, userIdentity, $q) {
     var vm = this;
     vm.domain = CONSTANTS.domain;
     vm.defaultPhotoUrl = CONSTANTS.ASSET_PREFIX + "images/avatarPlaceholder.png";
@@ -30,36 +30,26 @@
     function activate() {
       var handle = userIdentity.handle;
 
-      ProfileService.getUserProfile(handle)
-      .then(function(profile) {
-        vm.profile = profile;
-      });
+      $q.all([
+        ProfileService.getUserStats(handle),
+        ProfileService.getUserFinancials(handle)
+      ]).then(function(data) {
+        var stats = data[0];
+        var financials = data[1];
+
+        vm.moneyEarned = _.sum(_.pluck(financials, 'amount'));
 
-      ProfileService.getUserStats(handle)
-      .then(function(stats) {
         if (stats.COPILOT != null) {
           vm.numCopilotActiveContests = stats.COPILOT.activeContests;
         } else {
           vm.numCopilotActiveContests = 0;
         }
 
-        vm.rankStats = ProfileService.getRanks(stats);
-
-        if (vm.rankStats.length === 0) {
-          vm.hasRatings = false;
-        }
-
         vm.loading = false;
       })
       .catch(function(err) {
         vm.hasRatings = false;
         vm.loading = false;
-        // todo handle error
-      })
-
-      ProfileService.getUserFinancials(handle)
-      .then(function(financials) {
-        vm.moneyEarned = _.sum(_.pluck(financials, 'amount'));
       });
     }
   }

app/my-dashboard/header-dashboard/header-dashboard.jade

@@ -1,11 +1,11 @@
 header
   h1 My Dashboard
 
-  .user-stats(id="metrics")
+  .user-stats(id="metrics", ng-hide="vm.loading")
     .copilot-challenges(ng-show="dashboard.isCopilot")
       p.number(ng-bind='vm.numCopilotActiveContests')
 
-      p Active Challenges
+      p Copilot Challenges
 
     .slash(ng-show="dashboard.isCopilot")