Fixed Unit tests

Author: vikasrohit

app/account/login/login.spec.js

@@ -8,7 +8,10 @@ describe('Login Controller', function() {
   });
 
   beforeEach(function() {
-    controller = $controller('LoginController');
+    $scope = $rootScope.$new();
+    controller = $controller('LoginController', {
+      $scope : $scope
+    });
     $rootScope.$apply();
   });
 

app/directives/external-account/external-account.directive.spec.js

@@ -1,5 +1,5 @@
 /* jshint -W117, -W030 */
-describe.only('External Accounts Directive', function() {
+describe('External Accounts Directive', function() {
   var scope;
   var element;
 
@@ -66,13 +66,30 @@ describe('External Links Data Directive', function() {
   bard.verifyNoOutstandingHttpRequests();
 
   describe('Linked external accounts', function() {
+    var externalLinks = [
+      {
+        providerType: 'linkedin',
+        // don't care about other details
+      },
+      {
+        providerType: 'github'
+      },
+      {
+        providerType: 'behance'
+      },
+      {
+        providerType: 'dribbble'
+      },
+      {
+        providerType: 'bitbucket'
+      }
+    ];
     var linkedAccounts = {
       github: {
         handle: "github-handle",
         followers: 1,
         publicRepos: 1
       },
-
       stackoverflow: {
         handle: 'so-handle',
         reputation: 2,
@@ -83,7 +100,7 @@ describe('External Links Data Directive', function() {
         projectViews: 3,
         projectAppreciations: 3
       },
-      dribble: {
+      dribbble: {
         handle: 'dribble-handle',
         followers: 4,
         likes: 4
@@ -107,14 +124,16 @@ describe('External Links Data Directive', function() {
 
     beforeEach(function() {
       scope.linkedAccounts = linkedAccounts;
-      element = angular.element('<external-links-data linked-accounts-data="linkedAccounts"></external-links-data>)');
+      scope.externalLinks = externalLinks;
+      element = angular.element('<external-links-data linked-accounts-data="linkedAccounts" external-links="externalLinks"></external-links-data>)');
       externalLinksData = $compile(element)(scope);
       scope.$digest();
     });
 
     it('should have added linkedAccounts to scope', function() {
       expect(element.isolateScope().linkedAccounts).to.exist;
-      expect(element.isolateScope().linkedAccounts).to.have.length(1);
+      // linkedAccounts should have 5 entries because externalLinks contains only 5 records
+      expect(element.isolateScope().linkedAccounts).to.have.length(5);
     });
 
   });

app/my-dashboard/header-dashboard/header-dashboard.spec.js

@@ -121,9 +121,6 @@ describe('Header Dashboard Controller', function() {
     });
 
     it('variables should be initialized to correct value', function() {
-      expect(controller.domain).to.equal(domain);
-      expect(controller.isCopilot).to.equal(false);
-      expect(controller.hasRatings).to.equal(false);
       expect(controller.loading).to.equal(false);
       // TODO Fixme
       // expect(controller.profile).to.exist;
@@ -154,8 +151,6 @@ describe('Header Dashboard Controller', function() {
     });
 
     xit('variables should be initialized to correct value', function() {
-      expect(controller.domain).to.equal(domain);
-      expect(controller.isCopilot).to.equal(false);
       expect(controller.loading).to.equal(false);
       expect(controller.profile).not.to.exist;
       expect(controller.rankStats).to.exist;
@@ -186,8 +181,6 @@ describe('Header Dashboard Controller', function() {
     });
 
     xit('variables should be initialized to correct value', function() {
-      expect(controller.domain).to.equal(domain);
-      expect(controller.isCopilot).to.equal(false);
       expect(controller.loading).to.equal(false);
       expect(controller.profile).to.exist;
       expect(controller.profile.handle).to.equal('albertwang');

app/my-dashboard/my-dashboard.spec.js

@@ -1,10 +1,17 @@
 /* jshint -W117, -W030 */
 describe('Dashboard Controller', function() {
-  var controller, identity;
+  var controller, identity, profileService;
+  var mockProfile = mockData.getMockProfile();
 
   beforeEach(function() {
     bard.appModule('topcoder');
-    bard.inject(this, '$controller');
+    bard.inject(this, '$controller', '$q');
+
+    profileService = {
+      getUserProfile: function() {
+        return $q.when({result: {content: mockProfile}});
+      }
+    };
   });
 
   identity = function() {
@@ -18,11 +25,13 @@ describe('Dashboard Controller', function() {
 
   beforeEach(function() {
     controller = $controller('MyDashboardController', {
-      userIdentity: identity
+      userIdentity: identity,
+      ProfileService: profileService
     });
   });
 
   it('should exist', function() {
     expect(controller).to.exist;
+    expect(controller.isCopilot).to.equal(false);
   });
 });

app/profile/about/about.controller.js

@@ -22,8 +22,8 @@
 
     function activate() {
 
-      profileVm.externalLinksPromise.then(function() {
-        vm.linkedExternalAccountsData = profileVm.linkedExternalAccountsData;
+    ExternalAccountService.getLinkedExternalLinksData(profileVm.userHandle).then(function(data) {
+        vm.linkedExternalAccountsData = data.plain();
 
         // show section if user is viewing his/her own profile OR if we have data
         //vm.hasLinks = profileVm.linkedExternalAccounts.length;
@@ -53,6 +53,8 @@
           }
           profileVm.status.externalLinks = CONSTANTS.STATE_READY;
         }
+      }).catch(function(err) {
+        profileVm.status.externalLinks = CONSTANTS.STATE_ERROR;
       });
 
       profileVm.statsPromise.then(function() {

app/profile/badges/badges.spec.js

@@ -37,7 +37,8 @@ describe('Profile Badges Controller', function() {
     scope = $rootScope.$new();
     controller = $controller('BadgesController', {
       $scope: scope,
-      userHandle: 'vikasrohit'
+      userHandle: 'vikasrohit',
+      profile: {photoURL: "http://topcoder.com/test.png"}
     });
     $rootScope.$apply();
 

app/profile/profile.controller.js

@@ -58,13 +58,6 @@
       vm.status.skills = CONSTANTS.STATE_ERROR;
     });
 
-
-    vm.externalLinksPromise = ExternalAccountService.getLinkedExternalLinksData(vm.userHandle).then(function(data) {
-      vm.linkedExternalAccountsData = data.plain();
-    }).catch(function(err) {
-      vm.status.externalLinks = CONSTANTS.STATE_ERROR;
-    });
-
     function activate() {
       $log.debug('Calling ProfileController activate()');
       // show edit profile link if user is authenticated and is viewing their own profile

app/profile/profile.controller.spec.js

@@ -6,6 +6,7 @@ describe('Profile Controller', function() {
   var mockStats = mockData.getMockStats();
   var mockSkills = mockData.getMockSkills();
   var mockExternalLinks = mockData.getMockLinkedExternalAccounts();
+  var mockExternalLinksData = mockData.getMockLinkedExternalAccountsData();
 
   beforeEach(function() {
     bard.appModule('tc.profile');
@@ -25,7 +26,7 @@ describe('Profile Controller', function() {
 
     var externalAccountService = {
       getLinkedExternalLinksData: function() {
-        return $q.when(mockExternalLinks);
+        return $q.when(mockExternalLinksData);
       }
     }
     controller = $controller('ProfileCtrl', {
@@ -56,9 +57,10 @@ describe('Profile Controller', function() {
     });
 
     it('should have default status', function() {
+      expect(controller.status.badges).to.equal(CONSTANTS.STATE_LOADING);
       expect(controller.status.stats).to.equal(CONSTANTS.STATE_READY);
       expect(controller.status.skills).to.equal(CONSTANTS.STATE_READY);
-      expect(controller.status.externalLinks).to.equal(CONSTANTS.STATE_READY);
+      expect(controller.status.externalLinks).to.equal(CONSTANTS.STATE_LOADING);
     });
   });
 });

app/profile/subtrack/subtrack.spec.js

@@ -7,7 +7,7 @@ describe('SubTrack Controller', function() {
   var mockSkills = mockData.getMockSkills();
   var mockChallenges = mockData.getMockiOSChallenges();
   var mockHistory = mockData.getMockHistory();
-  var mockExternalLinks = mockData.getMockLinkedExternalAccounts();
+  var mockExternalLinksData = mockData.getMockLinkedExternalAccountsData();
   var apiUrl;
   var track = 'develop', subTrack = 'development';
   var profileScope, scope;
@@ -68,7 +68,7 @@ describe('SubTrack Controller', function() {
       .respond(200, {result: {content: mockSkills}});
     $httpBackend
       .when('GET', apiUrl + '/members/rakesh/externalAccounts/')
-      .respond(200, {result: { content: mockExternalLinks}});
+      .respond(200, {result: { content: mockExternalLinksData}});
 
     // mock profile api
     sinon.stub(profileService, 'getDistributionStats', function(track, subTrack) {

app/services/challenge.service.spec.js

@@ -7,7 +7,7 @@ describe('Challenge Service', function() {
     bard.appModule('tc.services');
     bard.inject(this, '$httpBackend', 'ChallengeService', 'CONSTANTS');
 
-    apiUrl = CONSTANTS.API_URL;
+    apiUrl = CONSTANTS.API_URL_V2;
   });
 
   bard.verifyNoOutstandingHttpRequests();

tests/test-helpers/mock-data.js

@@ -21,7 +21,8 @@ var mockData = (function() {
     getMockSRMResults: getMockSRMResults,
     getMockBadge: getMockBadge,
     getMockUserFinancials: getMockUserFinancials,
-    getMockLinkedExternalAccounts: getMockLinkedExternalAccounts
+    getMockLinkedExternalAccounts: getMockLinkedExternalAccounts,
+    getMockLinkedExternalAccountsData: getMockLinkedExternalAccountsData
   };
 
   function getMockStates() {
@@ -1934,7 +1935,7 @@ var mockData = (function() {
     }];
   }
 
-  function getMockLinkedExternalAccounts() {
+  function getMockLinkedExternalAccountsData() {
     return {
       github: null,
       stackoverflow: null,
@@ -1948,5 +1949,26 @@ var mockData = (function() {
     };
   }
 
+  function getMockLinkedExternalAccounts() {
+    return [
+      {
+        providerType: 'linkedin',
+        // don't care about other details
+      },
+      {
+        providerType: 'github'
+      },
+      {
+        providerType: 'behance'
+      },
+      {
+        providerType: 'dribbble'
+      },
+      {
+        providerType: 'bitbucket'
+      }
+    ];
+  }
+
 
 })();