Merge pull request #746 from appirio-tech/dev

nlitwin · nlitwin · commit 2e7697e7cc74 · 2016-03-15T10:43:31.000-07:00
Fix dashboard forum link
diff --git a/app/filters/challengeLinks.filter.js b/app/filters/challengeLinks.filter.js
@@ -38,7 +38,7 @@ import angular from 'angular'
           case 'data':
             return String.supplant('https://apps.{domain}/forums/?module=Category&categoryID={forumId}', data)
           case 'design':
-            return String.supplant('https://apps.{domain}/forums/?module=ThreadList&forumId={forumId}', data)
+            return String.supplant('https://apps.{domain}/forums/?module=ThreadList&forumID={forumId}', data)
           }
         /*eslint no-fallthrough:0*/
         case 'submissions':
diff --git a/app/filters/filters.spec.js b/app/filters/filters.spec.js
@@ -82,7 +82,7 @@ describe('filters', function() {
         subTrack : 'WEB_DESIGN'
       }
       expect(challengeLinksFilter(_ch, 'detail')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design')
-      expect(challengeLinksFilter(_ch, 'forums')).to.be.equal('https://apps.'+domain+'/forums/?module=ThreadList&forumId=2')
+      expect(challengeLinksFilter(_ch, 'forums')).to.be.equal('https://apps.'+domain+'/forums/?module=ThreadList&forumID=2')
       expect(challengeLinksFilter(_ch, 'registrants')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#viewRegistrant')
       expect(challengeLinksFilter(_ch, 'submissions')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#submissions')
     })

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ import angular from 'angular'`
`38`	`38`	`case 'data':`
`39`	`39`	`return String.supplant('https://apps.{domain}/forums/?module=Category&categoryID={forumId}', data)`
`40`	`40`	`case 'design':`
`41`		`- return String.supplant('https://apps.{domain}/forums/?module=ThreadList&forumId={forumId}', data)`
	`41`	`+ return String.supplant('https://apps.{domain}/forums/?module=ThreadList&forumID={forumId}', data)`
`42`	`42`	`}`
`43`	`43`	`/eslint no-fallthrough:0/`
`44`	`44`	`case 'submissions':`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ describe('filters', function() {`
`82`	`82`	`subTrack : 'WEB_DESIGN'`
`83`	`83`	`}`
`84`	`84`	`expect(challengeLinksFilter(_ch, 'detail')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design')`
`85`		`- expect(challengeLinksFilter(_ch, 'forums')).to.be.equal('https://apps.'+domain+'/forums/?module=ThreadList&forumId=2')`
	`85`	`+ expect(challengeLinksFilter(_ch, 'forums')).to.be.equal('https://apps.'+domain+'/forums/?module=ThreadList&forumID=2')`
`86`	`86`	`expect(challengeLinksFilter(_ch, 'registrants')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#viewRegistrant')`
`87`	`87`	`expect(challengeLinksFilter(_ch, 'submissions')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#submissions')`
`88`	`88`	`})`