Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 1acf4e7

Browse files
author
vikasrohit
committed
SUP-2895, [Profile/Dashboard] F2F challenges not displaying placement
-- Handled placement by looking into submission for F2F challenges.
1 parent 480c675 commit 1acf4e7

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

app/services/challenge.service.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,6 @@
180180
// process placement for challenges having winningPlacements array in response
181181
if (Array.isArray(challenge.userDetails.winningPlacements)) {
182182
challenge.highestPlacement = _.min(challenge.userDetails.winningPlacements);
183-
challenge.wonFirst = challenge.highestPlacement == 1;
184-
if (challenge.highestPlacement === 0) {
185-
challenge.highestPlacement = null;
186-
}
187183
}
188184
// process placement for design challenges
189185
if (challenge.track == 'DESIGN' && challenge.userDetails.submissions && challenge.userDetails.submissions.length > 0) {
@@ -192,11 +188,16 @@
192188
challenge.highestPlacement = _.min(challenge.userDetails.submissions.filter(function(submission) {
193189
return submission.placement;
194190
}), 'placement').placement;
195-
196-
if (challenge.highestPlacement == 1) {
197-
challenge.wonFirst = true;
198-
}
199191
}
192+
if (challenge.track === 'DEVELOP' && challenge.subTrack === 'FIRST_2_FINISH') {
193+
challenge.highestPlacement = _.min(challenge.userDetails.submissions.filter(function(submission) {
194+
return submission.status === 'Active' ? submission.placement : 0;
195+
}), 'placement').placement;
196+
}
197+
if (challenge.highestPlacement === 0) {
198+
challenge.highestPlacement = null;
199+
}
200+
challenge.wonFirst = challenge.highestPlacement == 1;
200201

201202
challenge.userHasSubmitterRole = false;
202203

0 commit comments

Comments
 (0)