SUP-3004, [Profile] Still showing placements outside of final submission range

-- Fixed showing placement outside of the winning placement boundaries and shown 'Passed Review' instead of placement for such challenges.

Author: vikasrohit

app/directives/challenge-user-place/challenge-user-place.directive.js

@@ -59,14 +59,6 @@ import _ from 'lodash'
             $scope.challenge.thumbnailId = $scope.challenge.userDetails.submissions[0].id
             $scope.imageURL = $scope.challenge.userDetails.submissions[0].submissionImage && $scope.challenge.userDetails.submissions[0].submissionImage.full
             $scope.selectedImage = $scope.imageURL
-
-            $scope.challenge.highestPlacement = _.min($scope.challenge.userDetails.submissions.filter(function(submission) {
-              return submission.type === CONSTANTS.SUBMISSION_TYPE_CONTEST && submission.placement
-            }), 'placement').placement
-
-            if ($scope.challenge.highestPlacement == 1) {
-              $scope.challenge.wonFirst = true
-            }
           }
         }
 

app/directives/challenge-user-place/design-challenge-user-place.jade

@@ -2,6 +2,7 @@
   p.place(ng-class="{ 'first-place': challenge.wonFirst }", ng-show="challenge.highestPlacement") {{challenge.highestPlacement}}#[span {{challenge.highestPlacement | ordinal:true}}] Place
   p.place.didnt(ng-show="challenge.userStatus === 'NOT_FINISHED'") Didn't Finish
   p.place.passed(ng-show="challenge.userStatus === 'PASSED_SCREENING'") Passed Screening
+  p.place(ng-show="!challenge.highestPlacement && challenge.userStatus === 'PASSED_REVIEW'") Passed Review
   p.place.completed(ng-show="challenge.userStatus === 'COMPLETED'") COMPLETED
 
   .thumbnail(ng-click="!challenge.isPrivate && imageURL && openLightbox()", ng-class="{hidden: challenge.userStatus !== 'PASSED_REVIEW'}")
@@ -23,6 +24,7 @@
     p.place(ng-class="{ 'first-place': challenge.wonFirst }", ng-show="challenge.highestPlacement") {{challenge.highestPlacement}}#[span {{challenge.highestPlacement | ordinal:true}}] Place
     p.place.didnt(ng-show="challenge.userStatus === 'NOT_FINISHED'") Didn't Finish
     p.place.passed(ng-show="challenge.userStatus === 'PASSED_SCREENING'") Passed Screening
+    p.place(ng-show="!challenge.highestPlacement && challenge.userStatus === 'PASSED_REVIEW'") Passed Review
     p.place.completed(ng-show="challenge.userStatus === 'COMPLETED'") COMPLETED
     p.date-completed {{challenge.submissionEndDate | date : 'MMMM yyyy'}}
 

app/directives/challenge-user-place/dev-challenge-user-place.jade

@@ -2,6 +2,7 @@
   p.place(ng-class="{ 'first-place': challenge.wonFirst }", ng-show="challenge.highestPlacement") {{challenge.highestPlacement}}#[span {{challenge.highestPlacement | ordinal:true}}] Place
     p.place(ng-show="challenge.userStatus === 'NOT_FINISHED'") Didn't Finish
     p.place(ng-show="challenge.userStatus === 'PASSED_SCREENING'") Passed Screening
+    p.place(ng-show="!challenge.highestPlacement && challenge.userStatus === 'PASSED_REVIEW'") Passed Review
     p.place(ng-show="challenge.userStatus === 'COMPLETED'") COMPLETED
 
   .challenge-score(ng-hide="challenge.userStatus !== 'PASSED_REVIEW'")
@@ -14,6 +15,7 @@
     p.place(ng-class="{ 'first-place': challenge.wonFirst }", ng-show="challenge.highestPlacement") {{challenge.highestPlacement}}#[span {{challenge.highestPlacement | ordinal:true}}] Place
     p.place(ng-show="challenge.userStatus === 'NOT_FINISHED'") Didn't Finish
     p.place(ng-show="challenge.userStatus === 'PASSED_SCREENING'") Passed Screening
+    p.place(ng-show="!challenge.highestPlacement && challenge.userStatus === 'PASSED_REVIEW'") Passed Review
     p.place(ng-show="challenge.userStatus === 'COMPLETED'") Completed
     p.date-completed {{challenge.submissionEndDate | date : 'MMMM yyyy'}}