Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 0d7e248

Browse files
author
vikasrohit
committed
SUP-1788, Join button on /register shows processing when button not clicked
-- Removed busy message for validations
1 parent 770a81b commit 0d7e248

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

app/account/register/register.controller.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
$log = $log.getInstance("RegisterController");
1010
$log.debug("-init");
1111
var vm = this;
12+
vm.registering = false;
1213
// prepares utm params, if available
1314
var utm = {
1415
source : $stateParams && $stateParams.utm_source ? $stateParams.utm_source : '',
@@ -39,6 +40,7 @@
3940
};
4041

4142
vm.register = function() {
43+
vm.registering = true;
4244
var userInfo = {
4345
handle: vm.username,
4446
firstName: vm.firstname,
@@ -78,12 +80,14 @@
7880
$log.debug('attempting to register user');
7981
TcAuthService.register(body)
8082
.then(function(data) {
83+
vm.registering = false;
8184
$log.debug('registered successfully');
8285

8386
// In the future, go to dashboard
8487
$state.go('registeredSuccessfully');
8588
})
8689
.catch(function(err) {
90+
vm.registering = false;
8791
$log.error('Error in registering new user: ', err);
8892
});
8993
};

app/account/register/register.jade

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,7 @@
8181

8282
p(ng-class="{ 'has-symbol-or-number': (vm.registerForm.password.$dirty && !vm.registerForm.password.$error.hasSymbolOrNumber) }") At least one number or symbol
8383

84-
button(type="submit", busy, busy-disabled="true", ng-disabled="vm.registerForm.$invalid", ng-class="{'enabled-button': vm.registerForm.$valid}") Join
85-
busy-message
86-
i.fa.fa-spinner(ng-bind="vm.busyMessage")
84+
button(type="submit", tc-busy-button, tc-busy-when="vm.registering", ng-disabled="vm.registerForm.$invalid", ng-class="{'enabled-button': vm.registerForm.$valid}") Join
8785

8886
section.terms
8987
p By clicking "Join," you agree to Topcoder's #[a(href="http://www.topcoder.com/community/how-it-works/terms/", target="_blank") Terms of Service] and #[a(href="http://www.topcoder.com/community/how-it-works/privacy-policy/", target="_blank") Privacy Policy]

0 commit comments

Comments
 (0)