Skip to content

Commit d9f760e

Browse files
sjswerdlowtonyzhc
authored andcommitted
Added fixes for test key handling.
1 parent c21fe9d commit d9f760e

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

pkg/common/parameters.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ import (
2222
)
2323

2424
const (
25+
// Disk Params
26+
ParameterAccessMode = "access-mode"
27+
2528
// Parameters for StorageClass
2629
ParameterKeyType = "type"
2730
ParameterKeyReplicationType = "replication-type"
@@ -157,7 +160,6 @@ func (pp *ParameterProcessor) ExtractAndDefaultParameters(parameters map[string]
157160
Tags: make(map[string]string), // Default
158161
Labels: make(map[string]string), // Default
159162
ResourceTags: make(map[string]string), // Default
160-
AccessMode: "READ_WRITE_SINGLE", // Default
161163
}
162164

163165
for k, v := range extraVolumeLabels {
@@ -266,6 +268,10 @@ func (pp *ParameterProcessor) ExtractAndDefaultParameters(parameters map[string]
266268
if paramEnableMultiZoneProvisioning {
267269
p.Labels[MultiZoneLabel] = "true"
268270
}
271+
case ParameterAccessMode:
272+
if v != "" {
273+
p.AccessMode = v
274+
}
269275
default:
270276
return p, fmt.Errorf("parameters contains invalid option %q", k)
271277
}

test/e2e/tests/single_zone_e2e_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -1785,7 +1785,8 @@ func deleteVolumeOrError(client *remote.CsiClient, volID string) {
17851785
func createAndValidateUniqueZonalMultiWriterDisk(client *remote.CsiClient, project, zone string, diskType string) (string, string) {
17861786
// Create Disk
17871787
disk := typeToDisk[diskType]
1788-
disk.params.AccessMode = "READ_WRITE_MANY"
1788+
1789+
disk.params[common.ParameterAccessMode] = "READ_WRITE_MANY"
17891790

17901791
volName := testNamePrefix + string(uuid.NewUUID())
17911792
volume, err := client.CreateVolumeWithCaps(volName, disk.params, defaultMwSizeGb,

0 commit comments

Comments
 (0)