Skip to content

Raise exception when watch returns an error #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacobHenner opened this issue Feb 13, 2021 · 0 comments · Fixed by #151
Closed

Raise exception when watch returns an error #134

JacobHenner opened this issue Feb 13, 2021 · 0 comments · Fixed by #151

Comments

@JacobHenner
Copy link
Contributor

In kubernetes_asyncio/watch/watch.py, there is a comment about raising an exception when a watch returns an error. Specifically:

# Something went wrong. A typical example would be that the user
# supplied a resource version that was too old. In that case K8s would
# not send a conventional ADDED/DELETED/... event but an error. Turn
# this error into a Python exception to save the user the hassle.
if js['type'].lower() == 'error':
return js

However, this doesn't seem to have been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant