fix: option verify-ssl impacts on server certs only (#46)

tomplus · web-flow · commit 47f1d182daf9 · 2018-10-09T00:14:48.000+02:00
diff --git a/kubernetes_asyncio/client/rest.py b/kubernetes_asyncio/client/rest.py
@@ -64,10 +64,13 @@ def __init__(self, configuration, pools_size=4, maxsize=4):
                 configuration.cert_file, keyfile=configuration.key_file
             )
 
+        if not configuration.verify_ssl:
+            ssl_context.check_hostname = False
+            ssl_context.verify_mode = ssl.CERT_NONE
+
         connector = aiohttp.TCPConnector(
             limit=maxsize,
-            ssl_context=ssl_context if configuration.verify_ssl else None,
-            verify_ssl=configuration.verify_ssl
+            ssl_context=ssl_context
         )
 
         # https pool manager

Original file line number	Diff line number	Diff line change
`@@ -64,10 +64,13 @@ def __init__(self, configuration, pools_size=4, maxsize=4):`
`64`	`64`	`configuration.cert_file, keyfile=configuration.key_file`
`65`	`65`	`)`
`66`	`66`
	`67`	`+ if not configuration.verify_ssl:`
	`68`	`+ ssl_context.check_hostname = False`
	`69`	`+ ssl_context.verify_mode = ssl.CERT_NONE`
	`70`	`+`
`67`	`71`	`connector = aiohttp.TCPConnector(`
`68`	`72`	`limit=maxsize,`
`69`		`- ssl_context=ssl_context if configuration.verify_ssl else None,`
`70`		`- verify_ssl=configuration.verify_ssl`
	`73`	`+ ssl_context=ssl_context`
`71`	`74`	`)`
`72`	`75`
`73`	`76`	`# https pool manager`