Skip to content

Create regression suite for #312 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tony opened this issue Apr 1, 2018 · 0 comments
Open

Create regression suite for #312 #375

tony opened this issue Apr 1, 2018 · 0 comments
Assignees

Comments

@tony
Copy link
Member

tony commented Apr 1, 2018

Effects issues like #312, and spin-off tickets like #326/#370 (focus), #364 ("no previous window)

See https://github.com/tmux-python/tmuxp/issues/364#issuecomment-377795942.

#312 needs a regression suite built around it.

It's necessary because 2.6 introduced an issue where the dimensions of unattached screens can't calculate layout info/switch layouts. get what I mean? That's why the hook was added.

The the thing is, the hook may need to be tailored to fit more specific instances so issues like this don't bubble up. Whether it's:

  • the conditions under which the hook itself is created
  • the hook's specificity to a target/global
  • when it's added in the workspace creation process, or
  • adding more conditions inside of the callback itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants