chore: Aggressive ruff fixes

ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes --ignore T201; ruff format .

Fixed 23 errors:
- docs/_ext/aafig.py:
    2 × COM812 (missing-trailing-comma)
- src/tmuxp/cli/load.py:
    1 × PLR5501 (collapsible-else-if)
- src/tmuxp/plugin.py:
    3 × FURB110 (if-exp-instead-of-or-operator)
- src/tmuxp/shell.py:
    6 × PGH004 (blanket-noqa)
    6 × RUF100 (unused-noqa)
- src/tmuxp/util.py:
    1 × PGH004 (blanket-noqa)
- src/tmuxp/workspace/builder.py:
    2 × COM812 (missing-trailing-comma)
- tests/workspace/test_builder.py:
    2 × PT014 (pytest-duplicate-parametrize-test-cases)

Author: tony

docs/_ext/aafig.py

@@ -193,7 +193,8 @@ def render_aafigure(
                 try:
                     try:
                         with open(
-                            metadata_fname, encoding=locale.getpreferredencoding(False)
+                            metadata_fname,
+                            encoding=locale.getpreferredencoding(False),
                         ) as f:
                             extra = f.read()
                     except Exception as e:
@@ -217,7 +218,9 @@ def render_aafigure(
     if options["format"].lower() == "svg":
         extra = visitor.get_size_attrs()
         with open(
-            metadata_fname, "w", encoding=locale.getpreferredencoding(False)
+            metadata_fname,
+            "w",
+            encoding=locale.getpreferredencoding(False),
         ) as f:
             f.write(extra)
 

src/tmuxp/cli/load.py

@@ -143,9 +143,8 @@ def _load_attached(builder: WorkspaceBuilder, detached: bool) -> None:
         builder.session.switch_client()  # switch client to new session
 
         os.environ["TMUX"] = tmux_env  # set TMUX back again
-    else:
-        if not detached:
-            builder.session.attach_session()
+    elif not detached:
+        builder.session.attach_session()
 
 
 def _load_detached(builder: WorkspaceBuilder) -> None:

src/tmuxp/plugin.py

@@ -157,25 +157,19 @@ def __init__(self, **kwargs: "Unpack[PluginConfigSchema]") -> None:
                 "version": self.tmux_version,
                 "vmin": config["tmux_min_version"],
                 "vmax": config["tmux_max_version"],
-                "incompatible": config["tmux_version_incompatible"]
-                if config["tmux_version_incompatible"]
-                else [],
+                "incompatible": config["tmux_version_incompatible"] or [],
             },
             "libtmux": {
                 "version": self.libtmux_version,
                 "vmin": config["libtmux_min_version"],
                 "vmax": config["libtmux_max_version"],
-                "incompatible": config["libtmux_version_incompatible"]
-                if config["libtmux_version_incompatible"]
-                else [],
+                "incompatible": config["libtmux_version_incompatible"] or [],
             },
             "tmuxp": {
                 "version": self.tmuxp_version,
                 "vmin": config["tmuxp_min_version"],
                 "vmax": config["tmuxp_max_version"],
-                "incompatible": config["tmuxp_version_incompatible"]
-                if config["tmuxp_version_incompatible"]
-                else [],
+                "incompatible": config["tmuxp_version_incompatible"] or [],
             },
         }
 

src/tmuxp/shell.py

@@ -51,10 +51,10 @@ class LaunchImports(t.TypedDict):
 def has_ipython() -> bool:
     """Return True if ipython is installed."""
     try:
-        from IPython import start_ipython  # NOQA F841
+        from IPython import start_ipython
     except ImportError:
         try:
-            from IPython.Shell import IPShell  # NOQA F841
+            from IPython.Shell import IPShell
         except ImportError:
             return False
 
@@ -67,7 +67,7 @@ def has_ptpython() -> bool:
         from ptpython.repl import embed, run_config  # F841
     except ImportError:
         try:
-            from prompt_toolkit.contrib.repl import embed, run_config  # NOQA F841
+            from prompt_toolkit.contrib.repl import embed, run_config
         except ImportError:
             return False
 
@@ -81,8 +81,8 @@ def has_ptipython() -> bool:
         from ptpython.repl import run_config  # F841
     except ImportError:
         try:
-            from prompt_toolkit.contrib.ipython import embed  # NOQA F841
-            from prompt_toolkit.contrib.repl import run_config  # NOQA F841
+            from prompt_toolkit.contrib.ipython import embed
+            from prompt_toolkit.contrib.repl import run_config
         except ImportError:
             return False
 
@@ -92,7 +92,7 @@ def has_ptipython() -> bool:
 def has_bpython() -> bool:
     """Return True if bpython is installed."""
     try:
-        from bpython import embed  # NOQA F841
+        from bpython import embed
     except ImportError:
         return False
     return True

src/tmuxp/util.py

@@ -69,7 +69,7 @@ def oh_my_zsh_auto_title() -> None:
     if (
         "SHELL" in os.environ
         and "zsh" in os.environ.get("SHELL", "")
-        and os.path.exists(os.path.expanduser("~/.oh-my-zsh"))  # NOQA PTH110, PTH111
+        and os.path.exists(os.path.expanduser("~/.oh-my-zsh"))  # NOQA: PTH110, PTH111
         and (
             "DISABLE_AUTO_TITLE" not in os.environ
             or os.environ.get("DISABLE_AUTO_TITLE") == "false"

src/tmuxp/workspace/builder.py

@@ -24,7 +24,7 @@
 def get_default_columns() -> int:
     """Return default session column size use when building new tmux sessions."""
     return int(
-        os.getenv("TMUXP_DEFAULT_COLUMNS", os.getenv("COLUMNS", COLUMNS_FALLBACK))
+        os.getenv("TMUXP_DEFAULT_COLUMNS", os.getenv("COLUMNS", COLUMNS_FALLBACK)),
     )
 
 
@@ -250,7 +250,7 @@ def build(self, session: t.Optional[Session] = None, append: bool = False) -> No
                 and os.getenv("TMUXP_DETECT_TERMINAL_SIZE", "1") == "1"
             ):
                 terminal_size = shutil.get_terminal_size(
-                    fallback=(get_default_columns(), get_default_rows())
+                    fallback=(get_default_columns(), get_default_rows()),
                 )
                 new_session_kwargs["x"] = terminal_size.columns
                 new_session_kwargs["y"] = terminal_size.lines

tests/workspace/test_builder.py

@@ -1169,32 +1169,6 @@ def test_find_current_active_pane(
         (
             textwrap.dedent(
                 """
-session_name: Should not execute
-windows:
-- panes:
-  - shell_command:
-    - cmd: echo "___$((1 + 3))___"
-      enter: false
-    """,
-            ),
-            "___4___",
-            False,
-        ),
-        (
-            textwrap.dedent(
-                """
-session_name: Should execute
-windows:
-- panes:
-  - shell_command: echo "___$((1 + 3))___"
-  """,
-            ),
-            "___4___",
-            True,
-        ),
-        (
-            textwrap.dedent(
-                """
 session_name: Should execute
 windows:
 - panes: