From c548e5e4bbaeb872bbf1ff3a2508a4b9ba2f775e Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 5 Nov 2022 11:12:09 -0500 Subject: [PATCH 1/3] test(test_capture_pane): Remove bashism --- tests/test_pane.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_pane.py b/tests/test_pane.py index 58def41f5..c9c658f6e 100644 --- a/tests/test_pane.py +++ b/tests/test_pane.py @@ -73,7 +73,7 @@ def test_capture_pane(session: Session) -> None: session.new_window( attach=True, window_name="capture_pane", - window_shell=f"{env} PS1='$ ' bash --norc --noprofile", + window_shell=f"{env} PS1='$ ' sh", ) pane = session.attached_window.attached_pane assert pane is not None From b778e039888f3a917197e33a18995a27cd4c0f37 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 5 Nov 2022 11:13:29 -0500 Subject: [PATCH 2/3] docs(common): bash -> console --- src/libtmux/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libtmux/common.py b/src/libtmux/common.py index 5376f8ef3..430053963 100644 --- a/src/libtmux/common.py +++ b/src/libtmux/common.py @@ -219,7 +219,7 @@ class tmux_cmd: Equivalent to: - .. code-block:: bash + .. code-block:: console $ tmux new-session -s my session From bdd71228ea008ee3ccb4b1d94b74dc3595f57fa7 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 5 Nov 2022 13:28:49 -0500 Subject: [PATCH 3/3] docs(CHANGES): Note removal of bashism --- CHANGES | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGES b/CHANGES index 9aa68ecb6..536d0b194 100644 --- a/CHANGES +++ b/CHANGES @@ -16,8 +16,12 @@ $ pip install --user --upgrade --pre libtmux ### Tests +_There will be more tests over the coming weeks and months to shore up +flakiness across shells and environments._ + - Compatibility improvement for `test_capture_pane` and `env` (#452), credit: @zappolowski! +- Remove more BASHisms from tests (#455) ## libtmux 0.15.9 (2022-10-30)