Skip to content

Commit 74d600b

Browse files
authored
test(test_capture_pane): Remove bashisms (#455)
In an effort to reduce reliance on specific shells so tests and development works across as many machines as possible, avoid explicitly mentioning shells. re: #454 There's an issue: What about fish? It departs greatly from other shells. Is there a way we can have tests and a capture_pane that works everywhere? #456
2 parents 5869e01 + bdd7122 commit 74d600b

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGES

+4
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,12 @@ $ pip install --user --upgrade --pre libtmux
1616

1717
### Tests
1818

19+
_There will be more tests over the coming weeks and months to shore up
20+
flakiness across shells and environments._
21+
1922
- Compatibility improvement for `test_capture_pane` and `env` (#452), credit:
2023
@zappolowski!
24+
- Remove more BASHisms from tests (#455)
2125

2226
## libtmux 0.15.9 (2022-10-30)
2327

src/libtmux/common.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ class tmux_cmd:
219219
220220
Equivalent to:
221221
222-
.. code-block:: bash
222+
.. code-block:: console
223223
224224
$ tmux new-session -s my session
225225

tests/test_pane.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def test_capture_pane(session: Session) -> None:
7373
session.new_window(
7474
attach=True,
7575
window_name="capture_pane",
76-
window_shell=f"{env} PS1='$ ' bash --norc --noprofile",
76+
window_shell=f"{env} PS1='$ ' sh",
7777
)
7878
pane = session.attached_window.attached_pane
7979
assert pane is not None

0 commit comments

Comments
 (0)