Skip to content

Commit 3389ec8

Browse files
committed
Avoiding flushing with every round
1 parent 72a10e3 commit 3389ec8

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

.flake8

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
[flake8]
2+
ignore =
3+
; except
4+
E722,
5+
; inline regex
6+
W605,
7+
; long lines
8+
E501,
9+
; too complex
10+
C901
11+
max-complexity = 10
12+
max-line-length = 120
13+
application-import-names = flake8

clickhouse_mysql/pumper.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def __init__(self, reader=None, writer=None):
2626
'UpdateRowsEvent': self.update_rows_event,
2727
'DeleteRowsEvent': self.delete_rows_event,
2828
# 'WriteRowsEvent.EachRow': self.write_rows_event_each_row,
29-
'ReaderIdleEvent': self.reader_idle_event,
29+
# 'ReaderIdleEvent': self.reader_idle_event,
3030
})
3131

3232
def run(self):
@@ -65,7 +65,7 @@ def update_rows_event(self, event=None):
6565
:param event:
6666
"""
6767
self.writer.update(event)
68-
68+
6969
def exit_gracefully(self, sig, frame):
7070
self.reader.close()
7171

clickhouse_mysql/reader/mysqlreader.py

+6-9
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from clickhouse_mysql.event.event import Event
1313
from clickhouse_mysql.tableprocessor import TableProcessor
1414
from clickhouse_mysql.util import Util
15-
from pymysqlreplication.event import QueryEvent, RotateEvent, FormatDescriptionEvent
1615

1716

1817
class MySQLReader(Reader):
@@ -32,7 +31,7 @@ class MySQLReader(Reader):
3231
exit_gracefully = False
3332

3433
write_rows_event_num = 0
35-
write_rows_event_each_row_num = 0;
34+
write_rows_event_each_row_num = 0
3635

3736
binlog_position_file = None
3837

@@ -323,7 +322,7 @@ def process_update_rows_event(self, mysql_event):
323322
# dispatch event to subscribers
324323

325324
# statistics
326-
#self.stat_write_rows_event_all_rows(mysql_event=mysql_event)
325+
# self.stat_write_rows_event_all_rows(mysql_event=mysql_event)
327326

328327
# dispatch Event
329328
event = Event()
@@ -356,13 +355,13 @@ def process_delete_rows_event(self, mysql_event):
356355
return
357356

358357
# statistics
359-
#self.stat_write_rows_event_calc_rows_num_min_max(rows_num_per_event=len(mysql_event.rows))
358+
# self.stat_write_rows_event_calc_rows_num_min_max(rows_num_per_event=len(mysql_event.rows))
360359

361360
if self.subscribers('DeleteRowsEvent'):
362361
# dispatch event to subscribers
363362

364363
# statistics
365-
#self.stat_write_rows_event_all_rows(mysql_event=mysql_event)
364+
# self.stat_write_rows_event_all_rows(mysql_event=mysql_event)
366365

367366
# dispatch Event
368367
event = Event()
@@ -422,8 +421,8 @@ def read(self):
422421
# skip other unhandled events
423422
pass
424423

425-
# after event processed, we need to handle current binlog position
426-
self.process_binlog_position(self.binlog_stream.log_file, self.binlog_stream.log_pos)
424+
# after event processed, we need to handle current binlog position
425+
self.process_binlog_position(self.binlog_stream.log_file, self.binlog_stream.log_pos)
427426

428427
except Exception as ex:
429428
if self.blocking:
@@ -468,12 +467,10 @@ def read(self):
468467
logging.info('end %d', end_timestamp)
469468
logging.info('len %d', end_timestamp - self.start_timestamp)
470469

471-
472470
def close(self):
473471
self.exit_gracefully = True
474472
self.nice_pause = 0
475473
logging.info("MySQL should stop in the next loop")
476-
477474

478475

479476
if __name__ == '__main__':

0 commit comments

Comments
 (0)