Cleaning usuless modifications

Author: Guts

mkdocs_git_revision_date_localized_plugin/plugin.py

@@ -20,7 +20,6 @@ class GitRevisionDateLocalizedPlugin(BasePlugin):
     )
 
     def __init__(self):
-        self.locale = "en"
         self.util = Util()
 
     def on_config(self, config: config_options.Config) -> dict:
@@ -41,44 +40,26 @@ def on_config(self, config: config_options.Config) -> dict:
 
         # Get locale settings - might be added in future mkdocs versions
         # see: https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/issues/24
-        mkdocs_locale = config.get(
-            "locale", None
-        )
+        mkdocs_locale = config.get("locale", None)
 
         # Get locale from plugin configuration
         plugin_locale = self.config.get("locale", None)
 
         # theme locale
         if "theme" in config and "locale" in config.get("theme"):
             custom_theme = config.get("theme")
-            if isinstance(custom_theme, Theme):
-                theme_locale = custom_theme._vars.get("locale")
-                logging.debug(
-                    "Locale '%s' extracted from the custom theme: '%s'"
-                    % (theme_locale, custom_theme.name)
-                )
-            elif isinstance(custom_theme, dict):
-                theme_locale = custom_theme.get("locale")
-                logging.debug(
-                    "Locale '%s' extracted from the custom theme: '%s'"
-                    % (theme_locale, custom_theme.get("name"))
-                )
+            theme_locale = custom_theme._vars.get("locale")
+            logging.debug(
+                "Locale '%s' extracted from the custom theme: '%s'"
+                % (theme_locale, custom_theme.name)
+            )
         elif "theme" in config and "language" in config.get("theme"):
             custom_theme = config.get("theme")
-            if isinstance(custom_theme, Theme):
-                theme_locale = custom_theme._vars.get("language")
-                logging.debug(
-                    "Locale '%s' extracted from the custom theme: '%s'"
-                    % (theme_locale, custom_theme.name)
-                )
-            elif isinstance(custom_theme, dict):
-                theme_locale = custom_theme.get("language")
-                logging.debug(
-                    "Locale '%s' extracted from the custom theme: '%s'"
-                    % (theme_locale, custom_theme.get("name"))
-                )
-            else:
-                pass
+            theme_locale = custom_theme._vars.get("language")
+            logging.debug(
+                "Locale '%s' extracted from the custom theme: '%s'"
+                % (theme_locale, custom_theme.name)
+            )
 
         else:
             theme_locale = None
@@ -88,25 +69,25 @@ def on_config(self, config: config_options.Config) -> dict:
 
         # First prio: plugin locale
         if plugin_locale:
-            self.locale = plugin_locale
-            logging.debug("Using locale from plugin configuration: %s" % self.locale)
+            locale_set = plugin_locale
+            logging.debug("Using locale from plugin configuration: %s" % locale_set)
         # Second prio: theme locale
         elif theme_locale:
-            self.locale = theme_locale
+            locale_set = theme_locale
             logging.debug(
                 "Locale not set in plugin. Fallback to theme configuration: %s"
-                % self.locale
+                % locale_set
             )
         # Third prio is mkdocs locale (which might be added in the future)
         elif mkdocs_locale:
-            self.locale = mkdocs_locale
-            logging.debug("Using locale from mkdocs configuration: %s" % self.locale)
+            locale_set = mkdocs_locale
+            logging.debug("Using locale from mkdocs configuration: %s" % locale_set)
         else:
-            self.locale = "en"
-            logging.debug("No locale set. Fallback to: %s" % self.locale)
+            locale_set = "en"
+            logging.debug("No locale set. Fallback to: %s" % locale_set)
 
         # set locale also in plugin configuration
-        self.config["locale"] = self.locale
+        self.config["locale"] = locale_set
 
         return config
 
@@ -130,7 +111,7 @@ def on_post_page(self, output_content: str, **kwargs) -> str:
             str: output of rendered template as string
         """
 
-        if self.config["type"] != "timeago":
+        if self.config.get("type") != "timeago":
             return output_content
 
         extra_js = """
@@ -170,7 +151,7 @@ def on_page_markdown(
 
         revision_dates = self.util.get_revision_date_for_file(
             path=page.file.abs_src_path,
-            locale=self.locale,
+            locale=self.config.get("locale", "en"),
             fallback_to_build_date=self.config.get("fallback_to_build_date"),
         )
         revision_date = revision_dates[self.config["type"]]
@@ -198,3 +179,6 @@ def on_page_markdown(
     assert plg.locale == "en"
     assert isinstance(plg.config, dict)
     assert plg.config == {}
+
+    plg.load_config({"locale": "fr"})
+    print(plg.config)