Upgraded to 1.23 (#89)

* adjustments for go 1.23 following changes in how certain types are handled in reflect

* remove dev todo comment

* upgrade workflow (#1)

fixed linter issues

Author: MichaelFraser1999

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go: ['1.21']
+        go: ['1.23']
     steps:
       - uses: actions/checkout@v4
       - name: Set up Go

.github/workflows/lint.yml

@@ -15,12 +15,9 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v4
       with:
-        go-version: '1.21'
+        go-version: '1.23'
 
     - name: Run golangci-lint
-      uses: golangci/golangci-lint-action@v3.7.0
+      uses: golangci/golangci-lint-action@v6.1.1
       with:
-        version: v1.54.0
-        # skip cache becausez of flaky behaviors
-        skip-build-cache: true
-        skip-pkg-cache: true
+        version: latest

.github/workflows/tag.yml

@@ -12,7 +12,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.21
+          go-version: 1.23
       - name: Unshallow
         run: git fetch --prune --unshallow
       - name: Create release

.golangci.yml

@@ -20,7 +20,7 @@ linters-settings:
     min-complexity: 15
   goimports:
     local-prefixes: github.com/timonwong/loggercheck
-  gomnd:
+  mnd:
     # don't include the "operation" and "assign"
     checks:
       - argument
@@ -36,7 +36,7 @@ linters-settings:
       - strings.SplitN
       - strconv.ParseInt
   govet:
-    check-shadowing: true
+    shadow: true
   lll:
     line-length: 140
   misspell:
@@ -52,15 +52,15 @@ linters:
     - dogsled
     - dupl
     - errcheck
-    - exportloopref
+    - copyloopvar
     - funlen
     - gochecknoinits
     - goconst
     - gocritic
     - gocyclo
     - gofumpt
     - goimports
-    - gomnd
+    - mnd
     - goprintffuncname
     - gosec
     - gosimple
@@ -85,10 +85,10 @@ issues:
   exclude-rules:
     - path: _test\.go
       linters:
-        - gomnd
+        - mnd
+  exclude-dirs:
+    - testdata
 
 run:
   timeout: 5m
-  go: '1.17'
-  skip-dirs:
-    - testdata
+  go: '1.23'

go.mod

@@ -1,16 +1,16 @@
 module github.com/timonwong/loggercheck
 
-go 1.21
+go 1.23
 
 require (
 	github.com/stretchr/testify v1.9.0
-	golang.org/x/tools v0.24.0
+	golang.org/x/tools v0.25.0
 )
 
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/mod v0.20.0 // indirect
+	golang.org/x/mod v0.21.0 // indirect
 	golang.org/x/sync v0.8.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -6,12 +6,12 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
 github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
-golang.org/x/mod v0.20.0 h1:utOm6MM3R3dnawAiJgn0y+xvuYRsm1RKM/4giyfDgV0=
-golang.org/x/mod v0.20.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
+golang.org/x/mod v0.21.0 h1:vvrHzRwRfVKSiLrG+d4FMl/Qi4ukBCE6kZlTUkDYRT0=
+golang.org/x/mod v0.21.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
 golang.org/x/sync v0.8.0 h1:3NFvSEYkUoMifnESzZl15y791HH1qU2xm6eCJU5ZPXQ=
 golang.org/x/sync v0.8.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
-golang.org/x/tools v0.24.0 h1:J1shsA93PJUEVaUSaay7UXAyE8aimq3GW0pjlolpa24=
-golang.org/x/tools v0.24.0/go.mod h1:YhNqVBIfWHdzvTLs0d8LCuMhkKUgSUKldakyV7W/WDQ=
+golang.org/x/tools v0.25.0 h1:oFU9pkj/iJgs+0DT+VMHrx+oBKs/LJMV+Uvg78sl+fE=
+golang.org/x/tools v0.25.0/go.mod h1:/vtpO8WL1N9cQC3FN5zPqb//fRXskFHbLKk4OW1Q7rg=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

internal/checkers/checker.go

@@ -30,8 +30,12 @@ func ExecuteChecker(c Checker, pass *analysis.Pass, call CallContext, cfg Config
 	startIndex := nparams - 1
 
 	lastArg := params.At(nparams - 1)
-	iface, ok := lastArg.Type().(*types.Slice).Elem().(*types.Interface)
-	if !ok || !iface.Empty() {
+	if iface, ok := lastArg.Type().(*types.Slice).Elem().(*types.Interface); !ok {
+		aface, ok := lastArg.Type().(*types.Slice).Elem().(*types.Alias) // slog uses any - an Alias not strictly an interface
+		if !ok || !aface.Underlying().(*types.Interface).Empty() {
+			return // final (args) param is not ...interface{}
+		}
+	} else if !iface.Empty() {
 		return // final (args) param is not ...interface{}
 	}
 

internal/checkers/filter.go

@@ -16,8 +16,13 @@ func filterKeyAndValues(pass *analysis.Pass, keyAndValues []ast.Expr, objName st
 		case *ast.CallExpr, *ast.Ident:
 			typ := pass.TypesInfo.TypeOf(arg)
 			switch typ := typ.(type) {
-			case *types.Named:
-				obj := typ.Obj()
+			case *types.Alias, *types.Named:
+				var obj *types.TypeName
+				if cTyp, ok := typ.(*types.Alias); ok {
+					obj = cTyp.Obj()
+				} else {
+					obj = typ.(*types.Named).Obj()
+				}
 				if obj != nil && obj.Name() == objName {
 					continue
 				}

internal/checkers/printf/printf.go

@@ -157,7 +157,7 @@ func (s *formatState) parsePrecision() bool {
 func parsePrintfVerb(format string) *formatState {
 	state := &formatState{
 		format: format,
-		flags:  make([]byte, 0, 5), //nolint:gomnd
+		flags:  make([]byte, 0, 5), //nolint:mnd
 		nbytes: 1,                  // There's guaranteed to be a percent sign.
 	}
 

internal/rules/rules_test.go

@@ -70,7 +70,6 @@ func TestParseFuncRule(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

internal/sets/string_test.go

@@ -44,7 +44,6 @@ func TestString_Flag(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

internal/stringutil/is_test.go

@@ -35,7 +35,6 @@ func TestIsASCII(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

loggercheck_test.go

@@ -84,7 +84,6 @@ func TestLinter(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			a := loggercheck.NewAnalyzer()
 			err := a.Flags.Parse(tc.flags)
@@ -177,7 +176,6 @@ func TestOptions(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			a := loggercheck.NewAnalyzer(tc.options...)
 

staticrules_test.go

@@ -42,7 +42,6 @@ func Test_mustNewStaticRuleSet_failCase(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			assert.PanicsWithError(t, tc.wantError, func() {